Vanilla Parts

Vanilla Parts

31k Downloads

LED Compatibility

ardissaps opened this issue ยท 3 comments

commented

LED

More information : magistermaks/mod-led#3

commented

(I'm getting a bit technical, sorry...) There are two possible explanations for this based on the crash report in the linked issue:

  1. A bug in Indium, actually - it can't process the button model I give it.
  2. A bug in Vanilla Parts (the BlocksToParts library actually) where I don't take into account uses of the Fabric Rendering API. This one seems unlikely though since LED doesn't seem to use the API.

The bugged rendering without colours is a bug in Vanilla Parts/BlocksToParts, which doesn't take into account original dynamic block colours.

commented

LED uses FRAPI extensively
i haven't investigated this issue myself yet so it may be something on my side, i will probably look into it by the end of the week and let you know if i could find a cause

commented

Ah yeah, then see this: https://github.com/Juuxel/BlocksToParts/blob/1ab8e7af897679d7e0f274461284fb45d5b8981a/src/main/java/juuxel/blockstoparts/impl/VanillaPartModel.java#L40-L52

My code is pretty naive and designed for vanilla models so it doesn't take any Meshes or anything into account, just checks the quads. Indium's fallback consumer doesn't really like that I pass it a null list of quads though, so it crashes.