Players can hear when vanished players pickup items

Question

Players can hear when vanished players pickup items

123456687548 opened this issue 4 years ago · 2 comments

123456687548 commented 4 years ago

Seems to be clientside

spaceclouds42 · Answer 1 · 2021-01-30T02:33:54.000Z

Found the packet: ItemPickupAnimationS2CPacket It is sent to the clients in the LivingEntity class in this method:

public void sendPickup(Entity item, int count) {
   if (!item.isRemoved() && !this.world.isClient && (item instanceof ItemEntity || item instanceof PersistentProjectileEntity || item instanceof ExperienceOrbEntity)) {
      ((ServerWorld)this.world).getChunkManager().sendToOtherNearbyPlayers(item, new ItemPickupAnimationS2CPacket(item.getId(), this.getId(), count));
   }
}

I haven't tested this, or even written it in an IDE, so it's liable to have some glaringly obvious issues, but this should fix it

@Mixin(LivingEntity.class)
public abstract class LivingEntityMixin {
   @Inject(method = "sendPickup", at = @At("HEAD"), cancellable = true)
   private void removePickUpNoise(Entity item, int count, CallbackInfo ci) {
      if (this instanceof ServerPlayerEntity && isVanished(this.getEntityName())) {
         ci.cancel();
      }
   }
   
   // Might be worth adding a Vanish::isVanished method
   private boolean isVanished(String name) {
      for (VanishedPlayer vanishedPlayer : Vanish.INSTANCE.getVanishedPlayers()) {
         if (name.equals(vanishedPlayer.getName())) {
            return true;
         }
      }
      return false;
   }
}

spaceclouds42 · Answer 2 · 2021-01-30T02:11:15.000Z

I think my suggestion in #14 could be applied here as well. With a mixin to the item pick up method, you could cancel the pick up, and then you could add those items directly into the player's inventory. Alternatively, the packet that sends that item pick up information to the clients could be canceled.

Share to