Vault Hunters compatability
HoYin1600p opened this issue ยท 4 comments
I am running several vault hunters modpack servers. They run on Forge, Minecraft version 1.18.2
We have a tile entity called an Animal Pen that allows for capture of farmable mobs to reduce entity strain on the servers.
I noticed today that when shearing the animal pen containing Sheep that the timer on the animal pen does not activate, making it possible to shear the sheep in the pen infinitely without cooldown. After reviewing the logs, they pointed towards Vanishmod (sadly)
I have confirmed by removing Vanishmod and testing that it is functioning as normal without it installed.
This is the relevant log. I would love to be able to keep the mod installed, however if this can't be fixed I will need to remove it.
Hello,
this is a known issue with Vanishmod on Minecraft version 1.18.2. At the point that this issue was first reported to me, I had already stopped supporting 1.18.2 for all my mods, so this issue never got fixed in 1.18.2 I'm afraid.
It might be possible to also circumvent this issue by changing the indirectSoundSuppression Vanishmod config value to false, but I'm not 100% certain about that.
I will close this issue since this is not going to get fixed in 1.18.2, but feel free to report back in here whether changing the config worked.
is there any reason to not release patch for this?
seems like all you need is a null check from this commit: 001d737
would you release a fix if we submit a pr or do we need to mixin the mod?
radimous: I will not upload a new 1.18.2 version of this mod for a single mod incompatibility fix, on the grounds of not wanting to endorse using a Minecraft version that is already almost 3 years old. So if you don't want to change the config value in the way described above, feel free to mixin into my mod for this fix (if it doesn't cause you too much trouble).