Variant Shields [Fabric/Quilt]

Variant Shields [Fabric/Quilt]

1M Downloads

[Feature Request] Compatibility with Passive Shield

SplendidAlakey opened this issue ยท 4 comments

commented

Hello, I'd like to request compatibility with the Passive Shield mod.

The dev of that mod says that mods need to "extend the ShieldItem in their Shield class".

A couple of working examples: MC Dungeons Weapons, The Bumblezone.

commented

Those 2 mods don't use fabric shield lib so extend they vanilla ShieldItem.
My shields extend FabricShieldItem as it was far easier to implement the shields.

Would be good if Passive Shield could work with fabric shield lib also

I'll look at changing it possibly in a later release, but doing so may delete existing shields in peoples inventories..

commented

I've raised it on Passive Shield git issues, seems a simple fix on that end tbh.
Serilum/.issue-tracker#1348

commented

apparently this should work now, untested however.

commented

It does not. I have the passive shield mod working for vanilla shields, as well as knightmetal shield from twilight forest, but not the variant shields. They do not hide like the others do.