ViaFabric

ViaFabric

Mods
709k Downloads

Possible incompatibly with the Essentials mod on 1.20

GrimPlayzs opened this issue · 5 comments

commented

/viaversion dump Output

https://dump.viaversion.com/94f8b92235c27a183ac23fde953d066ae34cf186d0af1183e2d3bd59d062454e

Console Error

No response

Bug Description

Game crashes upon going to the server list with the Essentials mod on 1.20. This did not occur on 1.19.4

Steps to Reproduce

Install both the Essentials mod and ViaFabric on 1.20
Launch the game and go to the server list.
Observe the crash.

Expected Behavior

The game should not crash with both mods working as intended.

Also, the crash log indicates it could be a GUI issue as both mods modify the server list screen with more buttons. I could be wrong though.

Additional Server Info

No response

Checklist

  • I have checked if this is specific to ViaFabric platform, and doesn't happen when running it on other platforms (Paper/Sponge/Velocity/Waterfall).
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.
commented

Please verify if this issue is also present on fabric itself and not just quilt.

commented

I can verify that this issue persists on fabric.

commented

Essentials is bad mod

  • 👍1
commented

This is caused by ViaFabric Redirecting a method call of which Essential tries to ModifyArg one of the arguments.
In general Redirect should be avoided because it's inherently incompatible with other mods. In this case, it seems trivial to replace with a ModifyArg (which not only allows different mods to modify different arguments of the same call, but even composes well when multiple mods target the exact same argument).