Villagers are sometimes named "Forename the"
Fourmisain opened this issue ยท 3 comments
professionNames, childNames and surNames were all set to true.
I think I found how to reproduce the issue.
Start with 2 villagers with professions like such:
Breed them.
Their child won't have a surname (which is already an issue I believe?) and will also have the profession text of their parent - which I'm not sure if intended. Is it?
When such a child grows up, it seems "the" is used as the surname
Though this apparently doesn't happen all the time?
Ahhh!
I wrote a whole paragraph here about how I'm trying to rewrite the naming functions, maybe the way names are stored etc.
I just compiled the code of my prototype wanted to do some testing to get a (draft) pull request up - but I noticed that the code here on github is outdated, it's still on version 1.5.2, please fix!
I just realized 1.6.0 is now pushed!
It's been so long since I wrote the rewrite that getting the PR done might take a while, if you want you can have a look at the (very unfinished) code.
Initially I wanted to add separate fields for fore- and surnames, but I quickly gave up on that idea (commented it out) since it's not hard using the simple "Forename <Surname> <the Jobtitle>" scheme, where you first split at the potential " the " and then at the potential space.
I remember thinking of having names with spaces but also thinking about config options which could cause issues, like the one that switches fore- and surnames:
If you generate villagers one way, switch the setting, restart and generate new villagers, it becomes impossible to distinguish between fore- and surnames, which would (especially) be an issue when they could have spaces.
That would be something separate fields could solve, but then you also need to think about custom names from nametags - another field? "realNameTagName"?
Seemed like too much effort and too error-prone due to the introduced redundancy, so I kept the basics and simplified it as much as I could in the brief time till I realized I worked with an out-of-date version.
