Vivecraft

Vivecraft

Mods
5M Downloads

little tiles conflict

fayer3 opened this issue ยท 8 comments

commented

these two mixins are conflicting
https://github.com/CreativeMD/LittleTiles/blob/bf2278ea20472e7fc44b2b1fe8ea7f37fb39d7ae/src/main/java/team/creative/littletiles/mixin/client/MinecraftMixin.java#L89-L92

VivecraftMod/common/src/main/java/org/vivecraft/mixin/client_vr/MinecraftVRMixin.java

Lines 569 to 572 in aa05773

@Redirect(at = @At(value = "INVOKE", target = "Lnet/minecraft/client/multiplayer/MultiPlayerGameMode;isDestroying()Z"), method = "startUseItem()V")
public boolean vivecraft$seatedCheck(MultiPlayerGameMode gameMode) {
return gameMode.isDestroying() && (!VRState.vrRunning || ClientDataHolderVR.getInstance().vrSettings.seated);
} 

littletiles.mixins.json:client.MinecraftMixin from mod littletiles->@Redirect::isDestroying(Lnet/minecraft/client/multiplayer/MultiPlayerGameMode;)Z with priority 1000, already redirected by vivecraft.mixins.json:client_vr.MinecraftVRMixin from mod vivecraft->@Redirect::vivecraft$seatedCheck(Lnet/minecraft/client/multiplayer/MultiPlayerGameMode;)Z with priority 1000
commented

a wrap should at least not crash I think

commented

Guess we can use something like wrap operation from mixin extra's to fix the conflict? I think we both would need to.

commented

if we also wrap after them, I think it should wrap the redirect

commented

What does this mixin actually do?

commented

seems to cancel the startUseItem in non seated mode

commented

sorry, read it backwards, if that returns true the method is canceled, but we seem to want to run it always in standing mode

commented

Made use of MixinExtra's wrapper operator, which should hopefully fix this issue.

commented

duplicate of #278 I somhow logged this twice