Vivecraft

Vivecraft

5M Downloads

1.21.3+ pose stack get's messed up when menuworld rendering fails midway though

fayer3 opened this issue ยท 3 comments

commented

when menuworld rendering fails, there is no backup to restore anything.
so the main posestack stays in the curretn state, which breaks almost eveyrting.
easy way to reproduce is to add polytone, it messes with the sky color, which fails when rendering the sky in the menuworld
https://modrinth.com/mod/polytone

commented

fixed that polytone issue, but the general issue still stands

commented

fixed it by popping the matrix stack when an exception happens.
there is technically still a chance that it happens when rendering the rain/snow though

commented

fixed, with a try / finally block around the code that modifies the posestack