Vivecraft

Vivecraft

5M Downloads

Exp orbs causing other particles to rotate

xanthousm opened this issue ยท 3 comments

commented

When an exp orb is rendered, its orientation is applied to all other particles. Screenshots below are from testing on fabric without any other mods installed. The first shows the exp orb (bottom left) that is affecting the smoke particle's orientation, the second shows how smoke and potion particles are being rotated by an exp orb directly below the player.

This bug is in the latest versions of both the 1.18 and 1.19 branches.

When iris+sodium are installed and a shader is used, this bug only appears in the left eye.

2022-10-06_10 54 33
Untitled

commented

likely an issue with billboarding textures

commented

I found the issue. The variable cameraorientation (used to rotate all particles) is being modified in two methods in mixin\client\renderer\entity\EntityRenderDispatcherVRMixin.java, when the methods should just be assigning a return value for each particle-like entity (snowballs and entity nametags caused the same issue).

As a fix, I just used a local Quaternion in the return statements instead (ec706f8).

commented

oh, I should have responded, I already fixed this locally, just didn't push yet.
basically did the same as you said