Very Many Players (Fabric)

Very Many Players (Fabric)

2M Downloads

Incompatibility with the "Modern Netty" mod

TheDGOfficial opened this issue ยท 0 comments

commented

Describe the bug
Mixin @Redirect conflict with defaultRequire=1 in vmp.mixins.json file causes a game crash when both mods (Modern Netty and Very Many Players) are installed. Modern Netty is a mod to make Minecraft use IOUring in Linux.

To Reproduce
Steps to reproduce the behavior:

  1. Install both mods and launch
  2. See the redirect conflict message on logs
  3. Watch how the game crashes because of injection failure due to defaultRequire=1

Expected behavior
Expected no conflicts as all my other mods work flawlessly with modern netty mod.

Screenshots
Does not apply

Runtime info (please complete the following information):

  • OS: Linux
  • Minecraft version: 1.21.8
  • Mod version: 0.2.0+beta.7.207+1.21.8
  • Mod branch: modrinth release

Crash reports / logs

[19:31:05] [Render thread/WARN]: @Redirect conflict. Skipping vmp.mixins.json:networking.avoid_deadlocks.MixinClientConnection from mod vmp->@Redirect::noDisconnectWait(Lio/netty/channel/ChannelFuture;)Lio/netty/channel/ChannelFuture; with priority 1050, already redirected by mnet.mixins.json:MixinConnection from mod mnet->@Redirect::swapChannelClient(Lio/netty/channel/ChannelFuture;)Lio/netty/channel/ChannelFuture; with priority 6969

The crash report is very long and does not provide much info than the warning above and uses obfuscated mappings, but I can add it if needed.

Other mods
Modern Netty

Checklist

  • I am using the official version of the mod.
  • I tried the latest development version but the issue persists.
  • I searched for similar open issues and could not find an existing bug report on this.

Additional context
Removing defaultRequire=1 from mvp.mixins.json fixes the issue, the warning message on the logs persists but is unharmful; everything works normally.

This only a workaround though; if this disconnection stall issue is still in effect with modern netty installed too, a solution to apply both mixins should be found, maybe using other injection types or MixinExtras.

If you think this should be fixed on "Modern Netty" mod developers side, let me know and I can close this and open an issue there.