Very Many Players (Fabric)

Very Many Players (Fabric)

2M Downloads

Incompatible with GraphLib (Wired Redstone)

sleepy-evelyn opened this issue ยท 1 comments

commented

Describe the bug
Occasionally when the world saves GraphLib (Used by Wired Redstone) causes a server crash when used in conjunction with VMP

To Reproduce
Make some changes to wired redstone in a world. Next time the world saves there is a possibility the server will crash

Runtime info (please complete the following information):

  • OS: Linux
  • Minecraft version: 1.20.1
  • Mod version: 0.2.0.beta.7.102

Crash reports / logs
Graphlib crash: https://gist.github.com/sleepy-evelyn/225486485b09e328ce1e09be1146f9b1
Main crash: https://gist.github.com/sleepy-evelyn/55e6d6f38b910de93701b032e7f43982

Other mods
Also using C2ME which might be relevant

Checklist

  • I am using the official version of the mod.
  • I tried the latest development version but the issue persists.
  • I searched for similar open issues and could not find an existing bug report on this.

Additional context
Kneelawk has admitted graphlib isn't threadsafe: Kneelawk/GraphLib#4

Not sure what to do really. It's become a big problem on the server and we can't just remove wiredredstone in it's entirety. VMP helps the server run at 20 TPS so idk haha.

commented

May have found the issue. Still need to test it but the crash is caused at the following line https://github.com/Kneelawk/GraphLib/blob/bcd35d39e7b20d1d34686be9a1fdbfbc09d978f4/modules/syncing-core-xplat/src/main/java/com/kneelawk/graphlib/syncing/impl/GraphLibSyncingImpl.java#L63
in graphlib. You can disable this form of version and config synchronisation in the config I think.

I still need to test though,