Voidscape

Voidscape

6M Downloads

SubCapability Performance

pitbox46 opened this issue ยท 2 comments

commented

The SubCapability class has very poor performance (taking up to 2.5% of tick time on the ATM9 modpack).
A lot of this seems to be because of a poor implementation of AttachedSubCap#tickers(). As it is, it unnecessarily runs .filter().map().toArray() every time it's called (which happens to be multiple times a tick). There doesn't seem to be any reason why these values can't be cached instead.
Also there's a lot of unnecessary converting things into streams which generally have more overhead than simple iterators/looping.

Spark Profile Screenshot
image

commented

That class doesn't exist anymore.

commented

Any plans to patch it for 1.20.1 Forge? I would patch it if I could myself, but the project is ARR...