Volumetric Flask

Volumetric Flask

81.7k Downloads

Configurable capacity

exzhawk opened this issue · 8 comments

commented

Allow user-defined arbitrary capacity. But still static, not in-game changeable
#7

commented

@exzhawk
hmmm i was thinking about this and how could we plannified this behavior with applied ...
And with the filler. Something has to change with the method the mod detect empty flask inside the ME system.
Instead of displaying every craft possible with every type of liquid, the filler has to get the amount of mb define by the user and configure itself the flask befose sending it to the crafting recipe
🤔

commented

Plan A:
Use item meta to store capacity. Need migration for old version saves.

commented

This feature could be neat !
I though about it, because there is so many recipies that use a certain amount of fluid that are not available in the mod.

But i was pretty lazy to setup a Java dev environment just to add these xD

commented

Since making capacity configurable compatibility, a whole redo of the capacity system might be considered. Plans:

  • Configure the capacity by shift-right click an empty volumetric flask.
  • Configure the capacity of an empty volumetric flask by using a workstation.
  • Use a workstation to craft volumetric flasks with arbitary capacity. No more changes after crafted.

If capacity is fully configurable, the mechanism of the Filler has to be changed. Currently, the Filler just provides every possible volumetric flask filled in every fluid that exists in the ME network. Plans:

  • Only provided certain fluids defined by a player.
  • Only provided certain volumetric flasks defined by a player.
  • Only provided certain volumetric flasks filled with certain fluids defined by a player.
commented

Sounds pretty good :D
If you need help testing these future features, let le know

commented

But i was pretty lazy to setup a Java dev environment just to add these xD

No need to setup a dev environment if you are so sure about what to change. GitHub will do the job for you.
Just fork the repo, make your changes, commit and push to your forked repo. Head to the Actions page of your repo, click on the lastest run, and download the file under Artifacts section. Unzip the downloaded artifact and use the JAR without "sources" in the filename.
A run on Actions page might take minutes to show up.

commented

Uuuu i didn't knew you can do that (yes i'm using github for more than 2 years now)

i'll take a look when i got some spare time and try to do something

commented

Could make a crafting recipe of 2x2 that cycles through the sizes.