VulkanMod

VulkanMod

357k Downloads

[Feature Request] Support for dynamic lighting

Danszerlied opened this issue ยท 5 comments

commented

Describe the request

It'd be very cool if Vulkan mod natively integrates dynamic handheld lighting, as no such mods are compatible with Vulkan mod atm (lambdynlights or ryoamiclights are incompatible)

commented

These mods may get support after the 0.5.0 release. You can already find the testing build with FRAPI support in VulkanMod Discord.

commented

This can be closed.

commented

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, as far as I know.

commented

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, we can't do anything.

LambDynamicLights uses LevelRender.getLightColor(BlockAndTintGetter, BlockState, BlockPos) as its injection point, and with several versions of similar rendering mods not requiring specific compatibility code anymore, I personally would rather avoid adding yet more fragile injections in my own mod.

Relevant issue on LambDynamicLights' side: LambdAurora/LambDynamicLights#238.

commented

Fixed by 349de86