ToolHelper.isToolEffectiveAgainst uses vanilla break speed method instead of Forge method

Question

ToolHelper.isToolEffectiveAgainst uses vanilla break speed method instead of Forge method

Choonster opened this issue 9 years ago · 3 comments

Choonster commented 9 years ago

The last line of ToolHelper.isToolEffectiveAgainst uses the vanilla ItemStack#func_150997_a method to get the tool's break speed for the block, but it should probably use the Forge-provided Item#getDigSpeed method instead since this is used for the actual break speed calculations when breaking blocks.

squeek502 · Answer 1 · 2015-10-31T19:14:10.000Z

Good call, thanks for letting me know about that.

Choonster · Answer 2 · 2015-10-31T19:15:16.000Z

Thanks for the quick fix. This should allow my custom swords to show as effective tools for Cobwebs.

squeek502 · Answer 3 · 2015-10-31T19:18:01.000Z

Released here: https://github.com/squeek502/WailaHarvestability/releases/tag/v1.1.5

Share to