Wallpapercraft - A Fresh Roll

Wallpapercraft - A Fresh Roll

688k Downloads

Newer Forge Versions Crash

WenXin20 opened this issue ยท 3 comments

commented

Minecraft v1.16.3
Forge v34.1.33
Wallpapercraft v1.4.5

Newer Forge versions are crashing due to a Forge change:

Error Log (Click Here)
[09:26:26] [Render thread/ERROR]: Exception caught during firing event: Can not register to a locked registry. Modder should use Forge Register methods.
  Index: 4
  Listeners:
  	0: NORMAL
  	1: ASM: net.minecraftforge.registries.DeferredRegister$EventDispatcher@213f5b4b handleEvent(Lnet/minecraftforge/event/RegistryEvent$Register;)V
  	2: ASM: class net.ommina.wallpapercraft.Wallpapercraft$RegistryEvents onItemsRegistry(Lnet/minecraftforge/event/RegistryEvent$Register;)V
  	3: ASM: class net.ommina.wallpapercraft.Wallpapercraft$RegistryEvents onBlocksRegistry(Lnet/minecraftforge/event/RegistryEvent$Register;)V
  	4: ASM: class net.ommina.wallpapercraft.Wallpapercraft$RegistryEvents registerSerials(Lnet/minecraftforge/event/RegistryEvent$Register;)V
java.lang.IllegalStateException: Can not register to a locked registry. Modder should use Forge Register methods.
  at net.minecraftforge.registries.NamespacedWrapper.register(NamespacedWrapper.java:56)
  at net.minecraftforge.registries.NamespacedWrapper.register(NamespacedWrapper.java:72)
  at net.minecraftforge.registries.NamespacedWrapper.func_218381_a(NamespacedWrapper.java:40)
  at net.minecraft.util.registry.Registry.func_218322_a(Registry.java:456)
  at net.minecraft.util.registry.Registry.func_218325_a(Registry.java:452)
  at net.minecraft.item.crafting.IRecipeSerializer.func_222156_a(IRecipeSerializer.java:39)
  at net.ommina.wallpapercraft.Wallpapercraft$RegistryEvents.registerSerials(Wallpapercraft.java:48)
  at net.minecraftforge.eventbus.ASMEventHandler_1086_RegistryEvents_registerSerials_Register.invoke(.dynamic)
  at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85)
  at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297)
  at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:120)
  at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:111)
  at net.minecraftforge.fml.ModContainer$$Lambda$3401/494865616.run(Unknown Source)
  at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618)
  at net.minecraftforge.fml.ModWorkManager$SyncExecutor.driveOne(ModWorkManager.java:56)
  at net.minecraftforge.fml.ModWorkManager$DrivenExecutor.drive(ModWorkManager.java:40)
  at net.minecraftforge.fml.ModLoader.waitForTransition(ModLoader.java:242)
  at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:229)
  at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:195)
  at net.minecraftforge.fml.client.ClientModLoader.lambda$begin$1(ClientModLoader.java:103)
  at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2939/1226973575.run(Unknown Source)
  at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:123)
  at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2940/1581377197.run(Unknown Source)
  at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:103)
  at net.minecraft.client.Minecraft.<init>(Minecraft.java:424)
  at net.minecraft.client.main.Main.main(Main.java:149)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:497)
  at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51)
  at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$484/405587614.call(Unknown Source)
  at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37)
  at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54)
  at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72)
  at cpw.mods.modlauncher.Launcher.run(Launcher.java:81)
  at cpw.mods.modlauncher.Launcher.main(Launcher.java:65)

[09:26:26] [Render thread/ERROR]: Caught exception during event RegistryEvent.Register<minecraft:recipe_serializer> dispatch for modid wallpapercraft
java.lang.IllegalStateException: Can not register to a locked registry. Modder should use Forge Register methods.
  at net.minecraftforge.registries.NamespacedWrapper.register(NamespacedWrapper.java:56) ~[?:?]
  at net.minecraftforge.registries.NamespacedWrapper.register(NamespacedWrapper.java:72) ~[?:?]
  at net.minecraftforge.registries.NamespacedWrapper.func_218381_a(NamespacedWrapper.java:40) ~[?:?]
  at net.minecraft.util.registry.Registry.func_218322_a(Registry.java:456) ~[?:?]
  at net.minecraft.util.registry.Registry.func_218325_a(Registry.java:452) ~[?:?]
  at net.minecraft.item.crafting.IRecipeSerializer.func_222156_a(IRecipeSerializer.java:39) ~[?:?]
  at net.ommina.wallpapercraft.Wallpapercraft$RegistryEvents.registerSerials(Wallpapercraft.java:48) ~[?:1.4.5]
  at net.minecraftforge.eventbus.ASMEventHandler_1086_RegistryEvents_registerSerials_Register.invoke(.dynamic) ~[?:?]
  at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-3.0.3-service.jar:?]
  at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297) ~[eventbus-3.0.3-service.jar:?]
  at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:120) [?:34.1]
  at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:111) [?:?]
  at net.minecraftforge.fml.ModContainer$$Lambda$3401/494865616.run(Unknown Source) [?:?]
  at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618) [?:1.8.0_51]
  at net.minecraftforge.fml.ModWorkManager$SyncExecutor.driveOne(ModWorkManager.java:56) [?:?]
  at net.minecraftforge.fml.ModWorkManager$DrivenExecutor.drive(ModWorkManager.java:40) [?:?]
  at net.minecraftforge.fml.ModLoader.waitForTransition(ModLoader.java:242) [?:?]
  at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:229) [?:?]
  at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:195) [?:?]
  at net.minecraftforge.fml.client.ClientModLoader.lambda$begin$1(ClientModLoader.java:103) [?:?]
  at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2939/1226973575.run(Unknown Source) [?:?]
  at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:123) [?:?]
  at net.minecraftforge.fml.client.ClientModLoader$$Lambda$2940/1581377197.run(Unknown Source) [?:?]
  at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:103) [?:?]
  at net.minecraft.client.Minecraft.<init>(Minecraft.java:424) [?:?]
  at net.minecraft.client.main.Main.main(Main.java:149) [?:?]
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
  at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
  at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.16.3-34.1.33.jar:34.1]
  at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$484/405587614.call(Unknown Source) [forge-1.16.3-34.1.33.jar:34.1]
  at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.5.jar:?]
  at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.5.jar:?]
  at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.5.jar:?]
  at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-8.0.5.jar:?]
  at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-8.0.5.jar:?]
[09:26:26] [Render thread/INFO]: Initializing sounds registration...
commented

Well that's novel.

Thank you for the report!

commented

forge: 1.16.3-34.1.34
wallpaper:
WallpaperCraft-1.16.3-1.4.5
addons:
WallpapercraftSlabs/stairs/walls-1.16.3-1.4.0
same here
logs:
latest.log

commented

Thanks SDUBZ.

I have a fix for this done, and will have it up on CurseForge in a few hours. Probably around eight hours from now by the time I get home and get it posted.