Waystones (Fabric Edition)

Waystones (Fabric Edition)

4M Downloads

[enhancement] Worldgen waystones are much to common.

MentalMouse opened this issue ยท 4 comments

commented

Having waystones produced in worldgen is a good idea, but as implemented, they're way too common.

Short of leaving them disabled entirely, the config file offers a minimum frequency of 1 in 10,000 blocks. That's a square 100 blocks on a side, which leaves them fairly well littering the landscape -- to the point that the only reason to make your own waystone would be to pick the name. (About that -- the person who activates it really should get to pick the name.)

My advice would be first, to change that frequency value to chunks, and second, to also add a minimum distance value. I also advise adding a separate enable/disable entry in the config file; this will let you supply default values, say 1 per 1000 chunks with a minimum distance of 300 blocks. (Those values may still be a bit low.)

commented

I don't think so: This was probably generated when I had it at 1000. Three in a row. (I've been raising it sharply since then,) There's a bunch more around my patch of forest, enough to make me believe it was made at 1 in 1000 blocks.

commented

World generation is per-chunk, not per-block.

https://github.com/blay09/Waystones/blob/1.11/src/main/java/net/blay09/mods/waystones/worldgen/WaystoneWorldGen.java#L26

It's a n/10000th chance. You had it at 1000, which results in a 10% chance per chunk. That's a lot and it's not surprising you ended up with three of them next to each other.

commented

Ah I see. I've seen so many mods doing chances as C/n that I automatically assumed it was that. Silly me.

I renew my suggestion of a separate enable/disable flag, allowing you to set reasonable defaults. (Also please fix/clarify the config comment for future users.)

commented

It already is 1 in 10000 chunks, the config comment is just a liar.