Waystones (Fabric Edition)

Waystones (Fabric Edition)

4M Downloads

Waystone's generated in game world cause game to hang

jack-cole opened this issue ยท 2 comments

commented

Minecraft Version

1.16

Mod Loader

Forge

Mod Loader Version

1.16.5-36.2.2

Mod Version

1.16.5-7.6.2

Describe the Issue

Mod Pack: Eigmatica 6.0.5.11
Additional mods (which may replace existing mods if newer version): AdChimneys-1.16.4-6.0.11.0-build.0144, AdPother-1.16.4-4.0.5.0-build.0142, camera-1.16.5-1.0.14, Chunk+Pregenerator-V1.16-3.1.1, citadel-1.8.1-1.16.5, ForgeEndertech-1.16.4-7.1.0.0-build.0075, iceandfire-2.1.9-1.16.5, ImmersiveEngineering-1.16.5-5.0.3-138, minecolonies-0.14.327-BETA-universal, moveplus-1.16.4-2.5.1, mowziesmobs-1.5.19, performant-1.16.2-5-3.72m, Psi+1.16-95, SereneSeasons-1.16.5-4.0.1.121-universal, spark-forge, structurize-0.13.208-ALPHA-universal

Description:
Whenever chunks are generated, there is a significant hiccup any time there's a waystone that has to be generated. When I disabled waystones from spawning in the world, the chunk generation speed doubled using the Chunk Generator mod.

I also have towers_of_the_wild-1.16.4-2.0.1, which I have seen cause lag when generating. I saw a cross section of a tower on the edge of a chunk, with most of it (including the waystone) in a chunk that hadn't generated and took quite a long time to appear.

Here is a spark profile, which clearly shows the waystone mod is causing lag: https://spark.lucko.me/pTErP2y0Xh

Logs

https://spark.lucko.me/pTErP2y0Xh

Do you use any performance-enhancing mods (e.g. OptiFine)?

performant-1.16.2-5-3.72m

commented

This also happens to me...

[19:29:01 ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH - 1.16.5-735 (MC: 1.16.5) ---
[19:29:01 ERROR]: The server has not responded for 25 seconds! Creating thread dump
[19:29:01 ERROR]: ------------------------------
[19:29:01 ERROR]: Current Thread:Server thread
[19:29:01 ERROR]: Stack:
[19:29:01 ERROR]: [email protected]/java.util.HashMap.getNode(HashMap.java:574)
[19:29:01 ERROR]: [email protected]/java.util.HashMap.containsKey(HashMap.java:591)
[19:29:01 ERROR]: [email protected]/java.util.HashSet.contains(HashSet.java:204)
[19:29:01 ERROR]: net.minecraft.world.server.ServerTickList.func_219504_a(ServerTickList.java:204)
[19:29:01 ERROR]: net.minecraft.world.server.ServerTickList.func_205362_a(ServerTickList.java:198)
[19:29:01 ERROR]: net.minecraft.world.ITickList.func_205360_a(SourceFile:9)
[19:29:01 ERROR]: net.minecraft.world.chunk.ChunkPrimerTickList.func_205381_a(SourceFile:45)
[19:29:01 ERROR]: net.minecraft.world.chunk.Chunk.func_222879_B(Chunk.java:872)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager.lambda$unpackTicks$36(ChunkManager.java:681)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager$$Lambda$12539/0x000000080238a440.apply(Unknown Source)
[19:29:01 ERROR]: com.mojang.datafixers.util.Either.lambda$mapLeft$0(Either.java:162)
[19:29:01 ERROR]: com.mojang.datafixers.util.Either$$Lambda$12338/0x00000008022f0440.apply(Unknown Source)
[19:29:01 ERROR]: com.mojang.datafixers.util.Either$Left.map(Either.java:38)
[19:29:01 ERROR]: com.mojang.datafixers.util.Either.mapLeft(Either.java:162)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager.func_222976_a_(ChunkManager.java:679)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager$$Lambda$12176/0x000000080229c840.apply(Unknown Source)
[19:29:01 ERROR]: [email protected]/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:642)
[19:29:01 ERROR]: [email protected]/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:478)
[19:29:01 ERROR]: net.minecraft.world.chunk.ChunkTaskPriorityQueueSorter.func_219083_b(SourceFile:58)
[19:29:01 ERROR]: net.minecraft.world.chunk.ChunkTaskPriorityQueueSorter$$Lambda$12218/0x00000008022b0840.run(Unknown Source)
[19:29:01 ERROR]: net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(ThreadTaskExecutor.java:153)
[19:29:01 ERROR]: net.minecraft.world.server.ServerChunkProvider$ChunkExecutor.func_213166_h(ServerChunkProvider.java:588)
[19:29:01 ERROR]: net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(ThreadTaskExecutor.java:126)
[19:29:01 ERROR]: net.minecraft.world.server.ServerChunkProvider$ChunkExecutor.func_213168_p(ServerChunkProvider.java:598)
[19:29:01 ERROR]: net.minecraft.util.concurrent.ThreadTaskExecutor.func_213161_c(ThreadTaskExecutor.java:136)
[19:29:01 ERROR]: net.minecraft.world.server.ServerChunkProvider.func_212849_a_(ServerChunkProvider.java:158)
[19:29:01 ERROR]: net.minecraft.world.World.func_217353_a(World.java:265)
[19:29:01 ERROR]: net.minecraft.world.IWorldReader.func_217348_a(IWorldReader.java:113)
[19:29:01 ERROR]: net.minecraft.world.World.func_212866_a_(World.java:261)
[19:29:01 ERROR]: net.minecraft.world.World.func_180495_p(World.java:544)
[19:29:01 ERROR]: net.minecraft.tileentity.TileEntity.func_195044_w(TileEntity.java:165)
[19:29:01 ERROR]: net.blay09.mods.waystones.tileentity.WaystoneTileEntityBase.getWaystone(WaystoneTileEntityBase.java:108)
[19:29:01 ERROR]: net.blay09.mods.waystones.tileentity.WaystoneTileEntityBase.func_189515_b(WaystoneTileEntityBase.java:43)

[19:29:01 ERROR]: net.minecraft.world.chunk.Chunk.func_223134_j(Chunk.java:483)
[19:29:01 ERROR]: net.minecraft.world.chunk.storage.ChunkSerializer.func_222645_a(ChunkSerializer.java:291)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager.func_219229_a(ChunkManager.java:715)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager.func_219185_a(ChunkManager.java:434)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager$$Lambda$13823/0x00000008025ec040.accept(Unknown Source)
[19:29:01 ERROR]: [email protected]/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)
[19:29:01 ERROR]: [email protected]/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:478)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager.func_223155_b(ChunkManager.java:416)
[19:29:01 ERROR]: net.minecraft.world.server.ChunkManager.func_219204_a(ChunkManager.java:394)
[19:29:01 ERROR]: net.minecraft.world.server.ServerChunkProvider.func_217207_a(ServerChunkProvider.java:388)
[19:29:01 ERROR]: net.minecraft.world.server.ServerWorld.func_72835_b(ServerWorld.java:484)
[19:29:01 ERROR]: net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:1032)
[19:29:01 ERROR]: net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334)
[19:29:01 ERROR]: net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:945)
[19:29:01 ERROR]: net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:760)
[19:29:01 ERROR]: net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:270)
[19:29:01 ERROR]: net.minecraft.server.MinecraftServer$$Lambda$11458/0x0000000801db7440.run(Unknown Source)
[19:29:01 ERROR]: [email protected]/java.lang.Thread.run(Thread.java:834)
[19:29:01 ERROR]: ------------------------------

commented

Probably same as #448