Waystones (Fabric Edition)

Waystones (Fabric Edition)

4M Downloads

Activating new waystone renable disabled waypoints in JourneyMap

MohamdSaan opened this issue ยท 4 comments

commented

Minecraft Version

1.16.x

Mod Loader

Forge

Mod Loader Version

36.2.16

Mod Version

7.6.4

Describe the Issue

Hi,

When I set the "displayWaystonesOnJourneyMap" to true in the config file and then activate a new waystone the waypoint is created correctly in journey map but the other waypoints (the ones created by the Waystones mod only) get all enabled and I have to disable them in journeymap again.

Step by step guide
set displayWaystonesOnJourneyMap to true in waystoned-client.toml
Activate some waystones and disable the created way points for them
Activate a new waystone

Regards

Logs

No response

Do you use any performance-enhancing mods (e.g. OptiFine)?

No response

commented

I don't think this can be easily fixed because the JourneyMap API does not provide access to waypoints that already exists, which means the only way to ensure these dynamic waypoints always reflect the actual waystones a player has activated is by removing all and recreating them.

Waystones could store a list of waypoints separately somewhere but since JourneyMap already has this information, it would be better to expand their API.

@mysticdrew Do you think we could get something like get(String modId, String id) or getAll(String modId) in the JourneyMap API?

commented

@mysticdrew Do you think we could get something like get(String modId, String id) or getAll(String modId) in the JourneyMap API?

Yup, that is coming when I get time, it is next on my list before the 5.8.0 release after I fix the stupid chunk caching issue causing the GC to go crazy.

commented

@blay09
So 5.8.0Beta17 when I release it for 1.18.2, 1.18.1, 1.17.1, and 1.16.5 will contain some new waypoint accessors and events.
In IClientAPI these methods for getting waypoints.

https://github.com/TeamJM/journeymap-api/blob/f96149575850c073e75c7be4be1814e5ede8ee86/src/main/java/journeymap/client/api/IClientAPI.java#L218-L249

will this work for you?

commented

should work for me, thanks