Quilt Incompatibility (Crash)
ElectroArtifex opened this issue · 6 comments
Minecraft Version
1.19.x
Mod Loader
Fabric
Mod Loader Version
Quilt Loader 0.17.1-beta.6
Mod Version
Waystones 11.0.1
Describe the Issue
When running with Quilted Fabric 0.17.1-beta.6, minecraft client crashes upon placing a waystone. This does not happen on Minecraft 1.19 with Fabric Loader 0.14.8, and so appears to be a compatibility issue with the Quilted Fabric API. I'm reporting this to Quilt as well, but wanted to make sure all sides are aware of the compatibility issue!
Logs
Do you use any performance-enhancing mods (e.g. OptiFine)?
No response
As I understand it, this is because the method is named sync rather than, e.g. waystonesSync. Prefixing with the mod name or modid is the convention here because not doing so will make the mod incompatible with any other mod or loader API doing the same thing.
If Quilt is injecting a method into my class it's their job to prefix their method. I can't prefix every method name I use at the off-chance that a third party injects a name conflict.
Quilt is injecting a method as the official API for a mod-loader. It makes sense for it to use an unprefixed method name, given that fact, IMO. I could be wrong, but I believe this is standard where Fabric does it as well - though I'll see if I can get input from someone more knowledgeable on that.
Alright, I've had a chat with the QSL team - they're removing the injection for now, and are looking at other approaches to solve the problems they were trying to address with this approach.
I'm not sure when the fix will be released, but I don't imagine it'll be a super long time.
This should be fixed in QSL 2.0.0-beta.11 and 2.0.0-beta.12 - mind double checking that?