Waystones (Fabric Edition)

Waystones (Fabric Edition)

4M Downloads

classloading issue causes banner patterns from other mods to not work

MehVahdJukaar opened this issue ยท 4 comments

commented

Minecraft Version

1.19.x

Mod Loader

Forge

Mod Loader Version

42.0.0

Mod Version

11.1.0

Describe the Issue

It seems that classloading Sheets class isnt safe to do at any time anymore. That's because banner patterns aren't an enum and have a proper registry instead. That class iterates over all the registered vaules and if loaded early it won't include modded ones. Tbh I'm not 100% sure about this and it also seems that if it was indeed an issue it would be somehting forge itself should fix. Letting you know so maybe we can have a look at this

Logs

No response

Do you use any performance-enhancing mods (e.g. OptiFine)?

No response

commented

This should be reported to Forge if that's the case, mods can't be expected to micromanage classloading of Minecraft classes within certain load stages. It's probably just an oversight in their banner pattern registry implementation.

commented

Yeah I agree. Found out about this since I too was doing the same. I brought this up on the discord and nobody replied lol

commented

I opened an issue here. Maybe bump it so it will get more attention MinecraftForge/MinecraftForge#8976

commented

This was fixed in the 1.19.3 port.