Waystones stop rendering and their names become invalid when used in a large modpack on a dedicated server, when Consistency+ and Universal Graves are present together
SplendidAlakey opened this issue ยท 3 comments
Minecraft Version
1.18.x
Mod Loader
Fabric
Mod Loader Version
0.13.3 + FAPI 0.48.0
Mod Version
10.0.0
Describe the Issue
Waystones/sharestones stop rendering and their names become "invalid" when I add the mod to my non-public modpack and join a dedicated server with the same modpack. Everything works perfectly fine in single-player.
I couldn't find out the exact steps to reproduce the issue other than having most of my mods installed along with Waystones, however, I first noticed the issue when I added Macaw's Roofs to my collection. But the mod itself doesn't seem to conflict with Waystones, because I tried loading just Macaw's Roofs + Waystones alone and it worked with no issues on both the server and single-player.
I tried removing mods 1 by 1, trying to figure out which combination of mods causes the conflict, but you pretty much need the entire modpack in order to reproduce the bug.
Mods that definitely don't need to be present for the bug to happen: Bedrockify, Charm, Minecraft Transit Railway, Adorn, Additional Additions. All the client-side mods like Continuity, CITResewn, TieFix (and similar bugfixing mods), MiniHUD (and other HUD mods like WTHIT), Sodium etc.
To get rid of the bug when all the mods are installed, removing only Macaw's Roofs helps, but as I said above, the mods don't conflict with each other on their own.
Another mod that can be removed to fix the bug is Consistency+, in which case Macaw's Roofs and Waystones work fine together along the rest of the modpack, but just like Macaw's Roofs, Consistency+ on its own doesn't cause any issues with Waystones.
I thought that maybe mods that add large amounts of blocks eventually cause the issue, so I only left such mods and tried to replicate the bug to no avail.
I'm honestly just hoping you could help identify what could cause the issue. I understand that my modpack is large and going through all the mod combinations will take an insane amount of time, and I'm not asking for that. However, I hope it would at least be possible to narrow down the mods that could cause this bug at all, so that I don't have to test every single mod combination.
Screenshots
Placing a waystone down, you can see that the waystone doesn't render at all
Right clicking on the ground next to the waystone with an empty hand, or the waystone itself, renders the bottom half of the waystone
Placing 2 blocks next to it (or even where it's actually supposed to be) makes the whole waystone render, but incorrectly - runes aren't glowing, no particles around the stone
Right clicking a waystone (even when it's invisible) opens the GUI like normal, but the name is "invalid" and can't be changed
Other than rendering and showing names, the waystones function as intended, you can teleport between them, scrolls work just fine (including having proper names) etc.
Logs
https://gist.github.com/Footage2-Amply-Pounce/824043b89fe9caae693367024f79e108
Do you use any performance-enhancing mods (e.g. OptiFine)?
Sodium + Indium + Sodium Extra, Lithium, LazyDFU, SmoothBoot, Phosphor, Krypton (server optimizations). Removing any/all off these mods doesn't affect the issue.
Edit: To add to the performance mods I use: EntityCulling. I noticed another thing that helps waystones to start rendering - leaving the area (and I assume unloading it) and then returning, completely fixes the waystone until you teleport (by any means, not just via waystones) again. However, removing EntityCulling doesn't help and it wouldn't explain why removing Consistency+ and Macaw's Roofs helps.
Bad news and good news. Good news: I found a way to replicate the bug without installing all of my mods and it might have nothing to do with your mod.
Bad news: I have no idea what exactly is going on, it just seems like that past a certain amount of mods, multiblocks from different mods, including Waystones, break.
To reproduce:
1. Install these mods: https://gist.github.com/Footage2-Amply-Pounce/7eea0c2703631e73a3ad1a945c3b36c5
2. Launch the game, join a server with the same mods; place a waystone, make sure it works
3. Close the game, install any of the following mods: Adorn, Blockus, Chipped or, possibly, any other mod that adds a lot of new blocks. I chose Adorn.
4. Launch the game, join the server and observe that waystones are now visually broken. However, Waystones isn't the only affected mod, if you place cables from the Tom's Simple Storage mod next to each other so they connect, you can also observe that, once connected, they become invisible until you right-click a block next to it (or place a block next to it). The difference is that waystones will stay invisible until the chunk unloads and will become invisible again after teleporting, whereas other mods' blocks only break when newly placed, after that they never glitch out.
After more testing, the above method no longer works for some reason, I heavily reduced the amount of mods needed to reproduce the issue and now it seems even more like Waystones has nothing to do with the bug. See my comment in the issue on Consistency+ github linked below for details. I will keep this issue open for now, but, again, the issue is probably not related to Waystones.
Logs following steps 1 and 2 (everything is fine): https://gist.github.com/Footage2-Amply-Pounce/ef09f9862a8d7523446a6aa8fa8362b0
Logs following steps 3 and 4 (multiblocks break): https://gist.github.com/Footage2-Amply-Pounce/a512bfe30c51b965a5ae9e14e4eccfb0
Since it's likely that the issue is not on your end, I might just have to live with it.
I can quickly cook up a test mod that outputs how many blocks were added just to see if theres an arbitrary or non-arbitrary number that has been hit. (Meant to put this in C+ Issue, but still applies for here)