Waystones

Waystones

123M Downloads

waystone consumes entire stacks of materials

Aceplante opened this issue ยท 4 comments

commented

Minecraft Version

Forge 1.18.2

Mod Loader

Forge

Mod Loader Version

1.18.2

Mod Version

10.2.1

Balm Version

3.2.6

Describe the Issue

whether you put one dust or 64 dust in each slot, it will all get consumed and only produce one attuned shard.

forge 1.18.2

Logs

No response

Do you use any performance-enhancing mods (e.g. OptiFine) or custom server distributions (e.g. SpongeForge)?

No response

commented

I came across this while iterating on #740 (in which this is partially fixed).

Attuned shards don't stack, so there's no real way of consuming more components to create more shards in the central slot... So instead we should create 1 shard using only the necessary components from the stacks. The ItemStacks must be shrinked by one, rather than emptied.

The tricky part is the central slot where the Flint goes: if a full stack of flint is placed, I don't think there's much of a choice but to destroy it in favor of storing the newly created shard in there.

commented

Maybe only accept one item then? It doesn't have to support stack crafting

commented

Feel free!

commented

@BlayTheNinth are you actively working on that one? Otherwise I could submit a PR, since I found out it would be technically fairly easy to limit the attunement slots size as per @Aceplante2 suggestion.