copygirl's Wearable Backpacks

copygirl's Wearable Backpacks

15M Downloads

Can Remove From Slot In Non-Vanilla Inventory GUIs

ChloeDawn opened this issue · 4 comments

commented

When accessing the chestplate slot via a third party GUI such as the Baubles or Aether Legacy inventories, the equipped wearable backpack can be freely removed from its slot.

Mod version: 3.1.2
Forge version: 1.12.2-14.23.2.2612

Baubles version: 1.5.2
Aether Legacy version: 2.0

commented

This is the reason why we need a canUnequip method on items or similar. Way back, I wanted to create a Forge PR to introduce this, in a way that would work for any number of custom equipment slots, but it was left to rot.

The only reason the backpack can't be removed from the Vanilly inventory GUI slot is because I replace the armor slot with my own.

This is already highly questionable but really the only way I could think of making backpacks work without interacting with the (in my opinion, back then, toxic) Forge community and waiting multiple months.

Obviously the current solution could be expanded to also replace other mod container slots through hacky ways, but I personally couldn't be bothered back then nor now. Sorry.

commented

But I can be bothered! Expect a fix for this in a few days.

commented

@asiekierka Fixing it by PRing something to Forge? More hardcoded hacks? Or a proper hack that fixes it for all GUIs? I imagine you could get all slots of open GUIs and replace the one the equipped backpack is sitting in dynamically...

Dang, now I want to do this.

commented

I'll be busy for most of today - if you pull it off before me, I won't do it obviously :P