[Localization] Hardcoded Translation Strings.
Amirhan-Taipovjan-Greatest-I opened this issue ยท 9 comments
Hello!
I found that this Mod has Strings that are hardcoded and can't be translated into other Languages...
There's Screenshots and Links to the .java Files with that Strings.
WeatherChanger.java
keys/*.java and WeatherChangerCommand.java
@Amirhan-Taipovjan-Greatest-I I have opened a PR that should fix this issue, could you please confirm that it fixes everything you would like?
Also feel free to submit PRs for translations.
Thanks
@Amirhan-Taipovjan-Greatest-I I have opened a PR that should fix this issue, could you please confirm that it fixes everything you would like?
Also feel free to submit PRs for translations.
Thanks
All commands.weatherchanger.set.*
Strings can't be used... I still see English... Fallback?.. even if I added Translations for them. The Key Bind Names are working perfectly!
(Interesting Fact: Minecraft Thunder Weather in Command Output described as "rain & thunder"; check Translations of commands.weather.set.thunder
String)
I think that ToggleClearKey.java
File also plays the Role in this Issue.
@Amirhan-Taipovjan-Greatest-I Should be fixed by 4c046a3
@Amirhan-Taipovjan-Greatest-I Should be fixed by 4c046a3
Yes, this Issue can be closed by that Commit!
Great! Will publish this as soon as possible.
Thank You! I also found someone who also wants to use this Mod in his Language, so I would be nice if new version will be published ASAP =)
Published version 1.0.1 ๐
Get the release
- Modrinth: https://modrinth.com/mod/weather-changer
- Curseforge (once approved): https://www.curseforge.com/minecraft/mc-mods/weather-changer
- GitHub Releases: https://github.com/Lucaslah/WeatherChanger/releases/tag/1.0.1