Weather Changer

Weather Changer

61.6k Downloads

[Localization] Hardcoded Translation Strings.

Amirhan-Taipovjan-Greatest-I opened this issue ยท 9 comments

commented

Hello!

I found that this Mod has Strings that are hardcoded and can't be translated into other Languages...

There's Screenshots and Links to the .java Files with that Strings.
WeatherChanger.java
keys/*.java and WeatherChangerCommand.java

commented

Hi, thanks for letting me know, Ill fix this as soon as possible.

commented

@Amirhan-Taipovjan-Greatest-I I have opened a PR that should fix this issue, could you please confirm that it fixes everything you would like?

Also feel free to submit PRs for translations.

Thanks

commented

@Amirhan-Taipovjan-Greatest-I I have opened a PR that should fix this issue, could you please confirm that it fixes everything you would like?

Also feel free to submit PRs for translations.

Thanks

All commands.weatherchanger.set.* Strings can't be used... I still see English... Fallback?.. even if I added Translations for them. The Key Bind Names are working perfectly!

image
(Interesting Fact: Minecraft Thunder Weather in Command Output described as "rain & thunder"; check Translations of commands.weather.set.thunder String)
image
image
image
image
image
image

I think that ToggleClearKey.java File also plays the Role in this Issue.

commented

Ah I see, looks like I missed a few things

commented
commented

@Amirhan-Taipovjan-Greatest-I Should be fixed by 4c046a3

Yes, this Issue can be closed by that Commit!

commented

Great! Will publish this as soon as possible.

commented

Great! Will publish this as soon as possible.

Thank You! I also found someone who also wants to use this Mod in his Language, so I would be nice if new version will be published ASAP =)

commented

Published version 1.0.1 ๐ŸŽ‰

Get the release