WebDisplays

WebDisplays

Mods
1M Downloads

URL logging can cause crashes

C1200 opened this issue ยท 0 comments

commented

The url method in net.montoyo.wd.entity.ScreenBlockEntity does not sanitize the URL it is passed when logging it out. This could cause a crash if the URL contains encoded text (such as %3A).

Here's the error it gives:

java.util.MissingFormatArgumentException: Format specifier '%3A'
	at java.util.Formatter.format(Formatter.java:2688) ~[?:?] {}
	at java.util.Formatter.format(Formatter.java:2625) ~[?:?] {}
	at java.lang.String.format(String.java:4145) ~[?:?] {re:mixin}
	at net.montoyo.wd.utilities.Log.info(Log.java:14) ~[webdisplays-2.0.2-1.20.1.jar%23174!/:2.0.2-1.20.1] {re:classloading}
	at net.montoyo.wd.entity.ScreenBlockEntity.url(ScreenBlockEntity.java:253) ~[webdisplays-2.0.2-1.20.1.jar%23174!/:2.0.2-1.20.1] {re:classloading}
[...]