Doctor Who:  Weeping Angels

Doctor Who: Weeping Angels

3M Downloads

large ServerLag

Closed this issue · 16 comments

commented

I'm using:
spongeforge API 7.1.0 v.3406
forge 1.12.2-14.23.4.2756

I'm running a server and recently i've seen large amounts of my resources going towards your mod.

Here's the spark profiling log:
https://sparkprofiler.github.io/?BmytD6Rbd6

and as you can see me.sub.angels.common.entities.EntityQuantumLockBase.func_70071_h_()
is taking 33% of my resources.

Please fix :) thank you!

commented

Hey, yeah this has been a issue I've been investigating ever since I added the whole "A angel freezes when it sees another one"

To further look into this, can I look into your Weeping angels config? I feel like I did something silly

commented
commented
   # Note: This a list of dimensions that angels should NOT teleport you to.
        I:notAllowedDimensions <
            TROPICS
            DIM-343800852
            343800852
         >

Unrelated to the issue at hand, but TROPICS won't fix anything here, only dimenion interger numbers for here

That aside, I'm just compiling a fix for you

Could you also tell me how you do your profiling? I would love to know in order to profile my mods in future

But if you could profile the next release I'm about to put out, that would be great!

commented

Considering Curse Forge can take awhile to allow a file to be allowed on their site
I sugget you try with this jar until they publish it: https://github.com/SandedShoes/Weeping-Angels/releases/tag/19.1

Thank you for reporting your issue and please do let me know how this fix goes <3

commented

to profile i use the spark profiling mod:
https://ore.spongepowered.org/Luck/spark

You run /profiler start whenever you experience lags or the perfomance could be better and shortly after you use /profiler stop.

I will take a look how it goes with your fix :) thank you!

commented

Anytime!

commented

Should be easy to fix if you switch to an active rather than a passive form of detection (Like I did when I did the teleporting stuff)

i.e. only check if an angel is quantum locked by another when that angel wants to move, instead of every single tick

commented

It's been moved to another branch if you want to take a look
I would myself but sorts occupied with stuff today

commented

@RedCriterion Hey, any update on this?

commented
commented

Ah that's great to here!
I assume you mean when players are in vanish and such?

commented
commented

Invisible sure, creative I'm iffy on
I can make a config option I guess, off by default

commented
commented

OH, you just mean the targeting?

commented

All sorted :)