
Raised fade timeout reveals some bugs
sudofox opened this issue ยท 1 comments
Hi, it's me again!
Loving the change to the higher possible fade timeout, but there's a few things that it's revealed as a result that weren't previously obvious.
- When all instances of the searched-for item is removed from a chest, the highlight doesn't update (even if you reopen the chest)
- When a shulker is broken (assuming chests also, haven't tested), the highlight remains there
- Selecting a new item to search for does not remove the old chest highlights, just adds new ones.
- Feature: There could be a button to clear existing highlights
- Feature: Maybe fade time could be in the settings menu so that you could do both mass-searching (many chests) or quick searching (just a few chests)
This mod has made my life 100x easier since previously I had to resort to writing things like this to figure out where I put my pickaxe.
Few new things in 1.14.0:
- Pressing the search hotkey clears previous highlights in world and inventories; if you don't hover over an item it will just clear them. (point 3, 4)
- There's now an optional client sided setting to limit the number of results returned (point 5).
As for the others, I haven't sorted them either for performance reasons (point 2, checking each highlighted spot if they change state on large highlight counts) or simplicity reasons (point 1, either the server scanning each inventory that was sent each tick and sending updates if items move, or doing some trickery on the client to remember what's been opened like in ChestTracker). Hopefully though, clearing items on hotkey press should make these 2 points less of an issue.
I appreciate all the feedback by the way, thank you.