Wilder Wild [Fabric]

Wilder Wild [Fabric]

1M Downloads

Partial incompatibility with Leaves Us In Peace

leiseg opened this issue · 4 comments

commented

Minecraft Version
Tested in 1.21.4 and 1.21.5.

Mods Used
Wilder Wild 4.0.2 (and it's dependencies)
Leaves Us In Peace 1.8.0

Description of the Bug Encountered
When both Wilder Wild and Leaves Us In Peace are installed, Palm Trees will no longer have or generate coconuts hanging from their leaves. This issue does not occur for Baobab Trees.

Steps To Reproduce

  1. Have the above mentioned mods installed for Minecraft 1.21.4 or 1.21.5.
  2. Create a new world.
  3. Locate a jungle or any other biome that generates with Palm Trees.
  4. See that there are no coconuts hanging from the leaves of Palm Trees.

Expected Behavior
Palm Trees should have coconuts hanging from their leaves when Leaves Us In Peace is installed. Baobab Trees seem similar to the way Palm Tress have "fruits" hanging off their leaves and they are fine when Leaves Us In Peace is installed.

Log
https://mclo.gs/4GFqL65

commented

The way coconuts are handled is actually very different.
Instead of using a tree decorator, it uses a mixin.
This ensures Coconuts can only place on leaves that are close enough to a log.
It also ensures that a minimum of two Coconuts will always generate.
Here is the relevant mixin: https://github.com/FrozenBlock/WilderWild/blob/master/src/main/java/net/frozenblock/wilderwild/mixin/worldgen/tree/TreeFeatureMixin.java

commented

Oh, that makes sense. Is this fixable from your side or should I open an issue about that for Leaves Us In Peace?

commented

I’d contact them first and ask them to take a look at my mixin. From there, they should be able to tell who can change what to get it to work, if even possible.

commented

Just unfortunate that tree decorator stuff runs prior to the leaves getting their distance properties set- I’d have no reason for that mixin if it worked that way.