Wizardry Mod

Wizardry Mod

6M Downloads

0.10.0 and Latest Library - Random Crash

HalestormXV opened this issue ยท 6 comments

commented

Random Crashes on 0.10.0 and latest Library. I can't seem to track it. Perhaps it has to do with Particle Effects or Shift clicking?

Crash Report
https://hastebin.com/iheyajukew.rb

This reproduces randomly. It has reproduced when I was around mobs with some particles and when I have tried shift clicking an item stack into a container (modded or vanilla chest even). I don't have much more to go on because it is seemingly random and I have no way to accurately reproduce it.

commented

The hastebin is empty, report it with pastebin or hasteb.in

commented

Woops, alright sorry about that. Here is the pastebin of the crash report:

https://pastebin.com/L0ieRUyj

After some further digging it would appear this does have something to do with the particle effects and their refreshing, specifically relating to the Projectile and Illuminate combo. It would appear these "random" crashes aren't so random as they are occurring in an area where I am using the Wizardry created lights from the Projectile Illumination spell.

commented

Ah, my bad. I'll add a world.isremote check and that should be that.

commented

You missed the point of my whole comment, see discord

commented

ParticleSpawner.spawn(glitter, world, new StaticInterp<>(new Vec3d(pos).add(0.5, 0.5, 0.5)), 1, 0, (i, build) -> {

You are spawning particles in the TE's update method, which can happen concurrently with client ticking, which is used to update particles.

My recommendations:

  • try to move to the new particle system if you can
  • use a custom renderer instead of this TE ticking hax (which is not at all meant for that kind of thing)
commented

After further consideration, it might fix it. I still recommend removing the whole ClientRunnable part as that will just create unnecessary inner classes instances.