[1.12.2] Compilation produces deobf jar
Brycey92 opened this issue ยท 3 comments
Issue Description
When I try to compile this manually on the 1.12 branch, after commenting out signJar, compilation produces a deobfuscated jar.
Reproduction Steps
Steps to reproduce the behavior:
- Comment out signJar everywhere it appears in build.gradle
- Add signJar's dependencies back to the dependency chain
- Run gradlew build
- Attempt to place armor on a tamed wolf
- Game crashes with an error stating a certain deobf function can't be found.
Expected Behavior
Compilation should reobfuscate references to Minecraft code before creating the jar files
Version Information:
- OS: Windows 7
- Java: Java 8
- Minecraft Version: 1.12.2
- Mod Version: From commit 6c4b6db
I'm unable to reproduce the issue in the latest version. I suspect that my recent update of the build.gradle toolchain has incidentally fixed it. Additionally as of 17282c9 you shouldn't need to comment out signJar; it'll be skipped and still allow you to build if no keyStore is specified. (That specific commit still has some issues, because I'm still not great w/ Gradle. I would recommend using b419494.)
I recently had issues w/ merging a feature branch into versions/1.12 and had to re-create the branch. I've also added some branch protection rules and a CI build to catch weird issues before they get merged. As for your fork, you may want to try rebasing your branches on upstream.
Please note that the latest version has several changes to configuration & no config GUI yet, so if you want to test specific features you'll have to edit the file manually.
I'm going to close this investigation as fixed. Let me know if you still have issues after the rebase; I can re-open then if you do.
see #109
i figured it out, the issue might be that the API wasn't properly reobfuscated. Fixed in v3.6.2.
Thanks!
Thanks for the fixes, and thanks for the tips too!
As for your fork, you may want to try rebasing your branches on upstream.
Luckily, a fix to #104 was all I was working on, but you've beaten me to it! I'll start a new fork next time I'm trying to add or change something.
Keep up the good work ๐