server locks up
Sunekaer opened this issue · 17 comments
https://raw.githubusercontent.com/Cerbrus/logfiles/main/debug.log
When user insert a Witch Controller or a Zombie controller into their Woot Magister-tier mobfarm, the server locks up.
https://github.com/FTBTeam/FTB-Presents-Direwolf20-1.16/issues/113
Hi, thanks for having a look at this.
If it would help, here's a backup setup to reproduce the issue:
https://drive.google.com/file/d/165Pl8E9VB5yzBoZvYD05S1cEz6H1eLMD/view?usp=sharing
Thanks for that - it should make it far easier for me to investigate and hopefully replicate without asking for 101 pieces of information. If I can get it to crash, then I can start adding some debug to find out what is going wrong.
Could you give me your top level woot/loot.json file as well.
I just booted your instance up in single plauer and successfully applied the witch and zombie controller, so I want to ensure I'm running exactly the same as you - thanks.
Sure thing, here it is:
https://raw.githubusercontent.com/Cerbrus/logfiles/main/loot.json
From the debug.log it looks like it happens when trying to learn the loot for the Witch in the simulator, however as the user says, there is no real clear crash happening, just an exit.
Running just the DW20 modpack in single player I can successfully insert a Witch controller.
The user seems to be running with a Skelton/Blaze/Enderman/Witch factory setup, so I'll try to run that configuration and see if I can recreate the issue there.
The last entry in their log related to Woot is:
[13Jan2021 12:45:18.515] [Server thread/DEBUG] [ipsis.woot.setup.ModSetup/]: Allocated minecraft:witch@0 to cell ipsis.woot.simulator.tartarus.Cell@68d289ab
Which I would expect to be followed up by three more lines of allocation so that gives me somewhere to look.
So the bad news is that I cannot replicate it so far - the image above is from the world download that you kindly provided. With you world load and loot file, I've managed to get the zombie, witch and wither controller all to work correctly.
Is there anything else about your setup that I could be missing?
ie.
any extra mods (didn't see any errors about that so I'm guessing not)
are you running this as single player or on a server?
Well that's good and bad news in one 😅
I'm running the game single player, from the FTB launcher. (On windows 10)
I created the world in modpack version 1.3.0, and encountered this issue in 1.3.1. I never installed any extra mods.
I must say I hadn't yet tried it again with pack version 1.4.0 that came out yesterday(?)
Well, I crossed my fingers, clenched my bottom and right-clicked the witch controller onto the factory... It didn't crash.
Wait... What?
So, I'm guessing this was some kind of conflict with another mod?
Yay, I guess 😅 Time to try the other controllers.
@AnotherPogo if you have a log from that it would be interesting to see it, as I think yours is a slightly different bug, simply because of the break heart fix you mention. (There is a chance yours is a ConcurrentModification exception which is something that I'm trying to work out from another bug)
@Cerbrus so your issue is around the learning of a new mob. Whenever a new controller is added with a new mob, I have to learn the loot drops. To do so I spawn some of the mobs in the Tartarus dimension. Your hang seems to be in a loop where I'm spawning the first mob at looting 0. For some reason we never progress past the first mob. Something along the code path of the spawn is causing Minecraft to lockup. I've looked through the code to try and work out what, but nothing looks wrong. So you have a chance to see this when you try new mob controller. However since you managed to get the wither/zombie working eventually it looks like it is something that can come and go. That is possibly why I couldn't replicate it. I'm going to continue trying to break your setup, but until I can replicate this I'm at a loss to what it might be.
I just had this same issue happen to me.
- Used the intern to upgrade a running Tier 1 factory (Zombies) into a Tier 2.
- Attempted to place a creeper controller onto the running Tier 2 Multiblock.
- After placing the block, the multiblock didn't change to include the new controller.
- After placing the block, JEI reported "waiting for server..." when looking at almost any block.
- After placing the block, Minecraft would not close. Menu allowed me to click the "Save and Quit to Title" button, but never returned to the main menu.
Some additional information:
- Mod Pack: FTB Present Direwolf20 1.16 version 1.3.1
- Playing single player.
- Issue did not occur if I break the factory heart before placing the new controller.
Let me know if you need any more information.
These seem to be the logs from before it happened.
https://raw.githubusercontent.com/AnotherPogo/dw20-bugs/master/Server%20Crash%20Bug/2021-01-22-1.log
https://raw.githubusercontent.com/AnotherPogo/dw20-bugs/master/Server%20Crash%20Bug/debug-1.log
I've got the world backup from before it happened, however that backup is from before I even crafted the items needed to upgrade from Tier 1 to Tier 2.
This morning I restored that world, and tried to recreate the same defect with no luck. I went through the same process of using the Intern to upgrade from Tier 1 to Tier 2 while the factory was running. This time around, the Tier 2 multiblock didn't form.
Breaking and replacing the Factory Heart resolved it without any further issues.
https://raw.githubusercontent.com/AnotherPogo/dw20-bugs/master/Multiblock%20Update%20Bug/latest.log
https://raw.githubusercontent.com/AnotherPogo/dw20-bugs/master/Multiblock%20Update%20Bug/debug.log
@AnotherPogo Multiblocks are always a pain as they need to communicate with each other. By placing the heart again, it basically nudges the multiblock tracker to rescan the whole factory, find all the blocks and connect them.
FYI, I had the problem (also with Witch and another one that I forget right now) but it only triggered when I broke another mob controller previously attached to the spawner and then immediately placed the new controller.
If I wait about 10-15 seconds between breaking and replacing (time for it to update its loot table I guess -- it usually takes about that long after placing a new controller before the GUI updates) then it works without crashes.
I managed to get it to fail once with the "waiting for server" with the world download. So I've added some debug and trying to get it to fail again. Hopefully the debug will give me some indication where it is stopping, so far I've yet to repeat the fail which is somewhat infuriating.