[1.16.5] Custom Mob drops specified by datapack do not drop more than 1 of any item

Question

[1.16.5] Custom Mob drops specified by datapack do not drop more than 1 of any item

SoxMax opened this issue 4 years ago · 3 comments

SoxMax commented 4 years ago

Mod version: 1.0.5.0
Forge version: 36.1.13

No other mods installed, added a single datapack with only one file woottest/data/woottest/recipes/factory/zombie.json.
File contents:

{
  "type": "woot:factory",
  "mob": "minecraft:zombie",
  "items": [ ],
  "fluids": [ ],
  "drops": [
    {
      "item": "minecraft:diamond",
      "sizes": [ 2, 2, 2, 2 ],
      "chances": [ 100.0, 100.0, 100.0, 100.0 ]
    }
  ]
}

I was expecting the factory to output 2 diamonds with every operation, but instead only got one. Factory had no perks installed.

Ipsis · Answer 1 · 2021-04-29T17:18:28.000Z

I use datapacks for the ender dragon, sheep and wither, however most of those are just stack sizes of 1, so it is completely possible there is a stack size issue.
I'll take a look at this and see what is going on.

Ipsis · Answer 2 · 2021-05-01T12:24:55.000Z

A bug - looks like custom drops could only ever drop a stack size of 1, as the "sizes" array is basically ignored. Will fix in the next release.

Ipsis · Answer 3 · 2021-05-01T12:30:17.000Z

[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop looting:0 1 diamond custom drop chance:100.0
[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop custom drop size 2 weight:1
[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop looting:1 1 diamond custom drop chance:100.0
[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop custom drop size 2 weight:1
[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop looting:2 1 diamond custom drop chance:100.0
[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop custom drop size 2 weight:1
[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop looting:3 1 diamond custom drop chance:100.0
[13:25:25] [Server thread/DEBUG] [ip.wo.se.ModSetup/]: SimulatedMobDrop custom drop size 2 weight:1

Share to