Workings

Workings

309k Downloads

Unused loot table throws errors in the log

EcoBuilder13 opened this issue ยท 2 comments

commented

Minecraft: 1.17.1
Workings: 1.0.7

The stop_sign_wall block has a loot table even though it's not a registered block causing an error to be thrown in the log.

[Render thread/ERROR]: Couldn't parse loot table workings:blocks/stop_sign_wall 
com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'workings:stop_sign_wall'

I would recommend removing the loot table as it's not used right now and you mentioned in a comment in Workings.java that you wanted it to be a block state instead of a separate block meaning it would use the stop_sign loot table.

commented

Couldn't parse loot table workings:blocks/stop_sign_wall
com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'workings:stop_sign_wall'
at Not Enough Crashes deobfuscated stack trace.(1.18.1+build.22) ~[?:?]
at net.minecraft.util.JsonHelper.method_17995(JsonHelper:130) ~[?:?]
at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
at net.minecraft.util.JsonHelper.asItem(JsonHelper:130) ~[?:?]
at net.minecraft.util.JsonHelper.getItem(JsonHelper:138) ~[?:?]
at net.minecraft.loot.entry.ItemEntry$Serializer.fromJson(ItemEntry:55) ~[?:?]
at net.minecraft.loot.entry.ItemEntry$Serializer.fromJson(ItemEntry:40) ~[?:?]
at net.minecraft.loot.entry.LeafEntry$Serializer.fromJson(LeafEntry:151) ~[?:?]
at net.minecraft.loot.entry.LeafEntry$Serializer.fromJson(LeafEntry:129) ~[?:?]
at net.minecraft.loot.entry.LootPoolEntry$Serializer.fromJson(LootPoolEntry:86) ~[?:?]
at net.minecraft.loot.entry.LootPoolEntry$Serializer.fromJson(LootPoolEntry:74) ~[?:?]
at net.minecraft.util.JsonSerializing$GsonSerializer.deserialize(JsonSerializing:102) ~[?:?]
at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:69) ~[gson-2.8.8.jar:?]
at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:41) ~[gson-2.8.8.jar:?]
at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[gson-2.8.8.jar:?]
at com.google.gson.Gson.fromJson(Gson.java:932) ~[gson-2.8.8.jar:?]
at com.google.gson.Gson.fromJson(Gson.java:1003) ~[gson-2.8.8.jar:?]
at com.google.gson.internal.bind.TreeTypeAdapter$GsonContextImpl.deserialize(TreeTypeAdapter.java:162) ~[gson-2.8.8.jar:?]
at net.minecraft.util.JsonHelper.deserialize(JsonHelper:448) ~[?:?]
at net.minecraft.util.JsonHelper.deserialize(JsonHelper:456) ~[?:?]
at net.minecraft.loot.LootPool$Serializer.deserialize(LootPool:173) ~[?:?]
at net.minecraft.loot.LootPool$Serializer.deserialize(LootPool:169) ~[?:?]
at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:69) ~[gson-2.8.8.jar:?]
at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:41) ~[gson-2.8.8.jar:?]
at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[gson-2.8.8.jar:?]
at com.google.gson.Gson.fromJson(Gson.java:932) ~[gson-2.8.8.jar:?]
at com.google.gson.Gson.fromJson(Gson.java:1003) ~[gson-2.8.8.jar:?]
at com.google.gson.internal.bind.TreeTypeAdapter$GsonContextImpl.deserialize(TreeTypeAdapter.java:162) ~[gson-2.8.8.jar:?]
at net.minecraft.util.JsonHelper.deserialize(JsonHelper:448) ~[?:?]
at net.minecraft.util.JsonHelper.deserialize(JsonHelper:466) ~[?:?]
at net.minecraft.loot.LootTable$Serializer.deserialize(LootTable:213) ~[?:?]
at net.minecraft.loot.LootTable$Serializer.deserialize(LootTable:209) ~[?:?]
at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:69) ~[gson-2.8.8.jar:?]
at com.google.gson.Gson.fromJson(Gson.java:932) ~[gson-2.8.8.jar:?]
at com.google.gson.Gson.fromJson(Gson.java:1003) ~[gson-2.8.8.jar:?]
at com.google.gson.Gson.fromJson(Gson.java:975) ~[gson-2.8.8.jar:?]
at net.minecraft.loot.LootManager.method_20711(LootManager:44) ~[?:?]
at dev.latvian.mods.kubejs.core.LootTablesKJS.applyKJS0(LootTablesKJS.java:38) ~[kubejs-fabric-1801.4.1-build.271.jar:?]
at net.minecraft.loot.LootManager.redirect$dni000$applyKJS(LootManager:2521) ~[?:?]
at net.minecraft.loot.LootManager.apply(LootManager:42) ~[?:?]
at net.minecraft.loot.LootManager.apply(LootManager:17) ~[?:?]
at net.minecraft.resource.SinglePreparationResourceReloader.method_18790(SinglePreparationResourceReloader:13) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18365(SimpleResourceReload:71) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18367(SimpleResourceReload:70) ~[?:?]
at java.util.concurrent.CompletableFuture$UniCompletion.claim(CompletableFuture.java:572) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714) ~[?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
at java.util.concurrent.CompletableFuture.postFire(CompletableFuture.java:614) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:726) ~[?:?]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18365(SimpleResourceReload:71) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18367(SimpleResourceReload:70) ~[?:?]
at java.util.concurrent.CompletableFuture$UniCompletion.claim(CompletableFuture.java:572) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714) ~[?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
at java.util.concurrent.CompletableFuture.postFire(CompletableFuture.java:614) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:726) ~[?:?]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18365(SimpleResourceReload:71) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18367(SimpleResourceReload:70) ~[?:?]
at java.util.concurrent.CompletableFuture$UniCompletion.claim(CompletableFuture.java:572) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714) ~[?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
at java.util.concurrent.CompletableFuture.postFire(CompletableFuture.java:614) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:726) ~[?:?]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18365(SimpleResourceReload:71) ~[?:?]
at net.minecraft.resource.SimpleResourceReload.method_18367(SimpleResourceReload:70) ~[?:?]
at java.util.concurrent.CompletableFuture$UniCompletion.claim(CompletableFuture.java:572) ~[?:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714) ~[?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147) ~[?:?]
at net.minecraft.class_4014$1.method_18374(class_4014.java:53) ~[server-intermediary.jar:?]
at net.minecraft.class_4014$1.whenPrepared(class_4014.java:50) ~[server-intermediary.jar:?]
at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150) [?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) [?:?]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1773) [?:?]
at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760) [?:?]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) [?:?]
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) [?:?]
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) [?:?]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) [?:?]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) [?:?]

Why NIC has to create more spam...

commented

Yeah the unused loot table spamming the log was fixed back in July of 2021 (6e305e5) I just haven't pushed and released the changes yet.
This small fix is rolled in with a whole bunch of very large changes, and I need time to properly test them. Never again will I release a large overhaul update haha, small incremental changes are much easier to deal with