World Pre Generator

World Pre Generator

2M Downloads

Pre generation crashes server upon completion when parallel generation is disabled

Wazbat opened this issue ยท 3 comments

commented

Versions
Minecraft Version: 1.18.2
Minecraft Forge Version: 40.1.74
Mod Version: 3.0.0

Log files
crash-2022-08-31_23.02.34-server.txt

Describe the bug
The server crashes upon finishing generation, after the dimensions have saved. This only happens if parallel generation is disabled, which is the default setting

To Reproduce
Steps to reproduce the behaviour:

  1. Install the mod
  2. Start a generation job, for example with 10 chunks as a radius
  3. Wait for it to finish
  4. Server crashes

Expected behaviour
Server to not crash when generating without parallel generation enabled

Additional context
I'm not super experienced with java, but I believe the issue lies in this file, specifically in the final shutdown method

The executor property is only assigned if ServerConfig.isRunParallel() is true, and there are checks for this in the generate method, however there are no checks for it in the final shutdown method

commented
Status:Fixed
Issue type:Critical Bug
Fix type:Bugfix
Fix version:3.0.1
Fix release date:01.09.2022

Issue confirmed for:

  • Multiple version

TODOs:

  • Implementing fix
commented

I fixed the issue with version 3.0.1.
Thank you for reporting the issue.

commented

Thanks for the quick fix!