WorldEdit

WorldEdit

43M Downloads

regen fails in 1.14

LadyCailinBot opened this issue · 12 comments

commented

WORLDEDIT-3888 - Reported by SlimeDog

Spigot 1.14 (2235)
WE 7.0.0-SNAPSHOT;4213-d48702a

//chunk
//regen

doesn't.

[14:16:22] [Server thread/INFO]: PLAYER_MASKED issued server command: //chunk
[14:16:35] [Server thread/INFO]: PLAYER_MASKED issued server command: //regen
[14:16:35] [Server thread/WARN]: Chunk generation via Bukkit raised an error
java.lang.UnsupportedOperationException: Not supported in this Minecraft version! Unless you can fix it, this is not a bug :)
        at org.bukkit.craftbukkit.v1_14_R1.CraftWorld.regenerateChunk(CraftWorld.java:400) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at com.sk89q.worldedit.bukkit.BukkitWorld.regenerate(BukkitWorld.java:182) ~[?:?]
        at com.sk89q.worldedit.command.RegionCommands.regenerateChunk(RegionCommands.java:358) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
        at com.sk89q.worldedit.util.command.parametric.ParametricCallable.call(ParametricCallable.java:243) ~[?:?]
        at com.sk89q.worldedit.util.command.SimpleDispatcher.call(SimpleDispatcher.java:125) ~[?:?]
        at com.sk89q.worldedit.extension.platform.CommandManager.handleCommand(CommandManager.java:286) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
        at com.sk89q.worldedit.util.eventbus.MethodEventHandler.dispatch(MethodEventHandler.java:58) ~[?:?]
        at com.sk89q.worldedit.util.eventbus.EventHandler.handleEvent(EventHandler.java:73) ~[?:?]
        at com.sk89q.worldedit.util.eventbus.EventBus.dispatch(EventBus.java:187) ~[?:?]
        at com.sk89q.worldedit.util.eventbus.EventBus.post(EventBus.java:173) ~[?:?]
        at com.sk89q.worldedit.bukkit.WorldEditPlugin.onCommand(WorldEditPlugin.java:295) ~[?:?]
        at com.sk89q.bukkit.util.DynamicPluginCommand.execute(DynamicPluginCommand.java:54) ~[?:?]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at org.bukkit.craftbukkit.v1_14_R1.CraftServer.dispatchCommand(CraftServer.java:707) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.PlayerConnection.handleCommand(PlayerConnection.java:1666) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1506) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:1) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:13) ~[spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:135) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:114) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.MinecraftServer.aW(MinecraftServer.java:892) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:885) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(SourceFile:99) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:868) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:802) [spigot-1.14.jar-2019-04-30-0641:git-Spigot-1eece4f-dadc539]
        at java.lang.Thread.run(Thread.java:834) [?:?]
commented

Comment by me4502

Looks like Spigot haven’t updated their regeneration functions yet.

commented

Comment by SlimeDog

Or they have been renamed? Or...?
Are you going to file a Spigot ticket?

commented

Comment by wizjany

it's public bukkit API. it's not an issue of being renamed. spigot just needs to implement it again. feel free to file a ticket yourself if you want, but it's up to them to do it.

commented

Comment by SlimeDog

ok.

commented

Comment by SlimeDog

Based on md_5's comments, I'm guessing that CraftWorld.regenerateChunk() has been deprecated and removed, and is not likely to return. Is WE planning to support chunk regeneration in some other form, or is it gone for good?

https://hub.spigotmc.org/jira/browse/SPIGOT-4266

commented

Comment by wizjany

looks completely unrelated. he mentions deprecation is due to odd behavior, not to "it's going to be removed"

commented

Comment by SlimeDog

Yet it does not exist in Spigot 1.14. I certainly don't get the sense that Spigot 1.14 is code-incomplete.
What is a poor WE user to do? I use //regen a lot to test my private biome remapping plugin.

commented

Comment by SlimeDog

At the least, WE needs to report an error to the //regen invoker. Despite the console error, in-game returns the selection was regenerated.

commented

Comment by me4502

Spigot has been code incomplete for years, it gets worse every version with things being “maybe” fixed in the future.

Once 1.14 has stabilised, we can work out a replacement regen system. Until then, it looks temporarily disabled in Spigot.

commented

Comment by SlimeDog

OK, thanks.

commented

Comment by woogoo

From comments on Spigot, it appears that they don't feel there is any need for this function and definitely won't be of any priority in the near future. Can we expect WorldEdit to possibly implement a plugin side feature for terrain regeneration, or can we considered //regen a dead command?

commented

Comment by wizjany

feel free to PR it (either to WE or to Spigot) then. in the meantime, you can use //restore or /delchunks depending on your situation.
//regen isn't a dead command because it still works fine on other platforms.