//undo (Number) breaks if number is higher than actions done
lSherozl opened this issue · 12 comments
Version 1.15.2(Latest)
I think I found a bug, idk if it's intentional or not, If I use the brush tool, a sphere with air, and I do a bunch of spheres into the ground, then I undo, it works well, say I used the brush 10 times, and I do //undo 5 it will work, but if I go //undo 20 or go over the number of times I used the brush, it will forget what was done, and say "nothing left to undo", and even forget about it if you went //undo only once afterwards
That’s not a bug. There’s a limit to the history size that’s configurable in the config. If you want it to be higher, increase it. Do note that it’ll use more memory
I see so what is the option called in the config to raise the history? And is there any way to stop it from forgetting the previous things, if you accidentally did //undo number too high, because it will erase everything it remembered once u screw that up
For example, if I use the brush 20 times right, //undo 10, it will undo 10 times for me, now I only have 10 actions that I did, but now if I go, //undo 12, it will say "nothing left to undo" which is fine because I went over the amount of actions I did, but as soon as I have went over, and I type even //undo 2, //undo 5 it does not matter how many actions I had left, it will not allow me to undo further as soon as I go over, its as if my 10 actions got erased from the history, it will continue to give me the "nothing left to undo" thing, even if I had things that could be undone, and it also doesn't restore everything to the beginning when u have gone over with the undo, so your stuck with what you did with no way to undo further
I still don’t understand, what do you expect it to do once you’ve reached the end of history? If there’s nothing left to undo, there’s nothing left to undo?
Sorry I checked you answered my question, raising the history will allow you to undo a higher amount without that error preventing you from undoing further
I currently don’t have a desk so can’t check currently, but I’ll double check when I next get to a computer whether progressing the history pointer too far progresses the pointer without actually undoing the entries. I believe that’s what the issue you were experiencing there is
I’ll re-open the issue as a reminder for me to check
I cannot reproduce this bug, with a history-size=15 in the config, if you do 20 brush actions, WorldEdit correctly remembers only 15 of them, and doing //undo 10 + //undo 12 results in the following chat messages:
And it does undo 15 brush actions, as the chat messages say. It will not undo any more actions, because WorldEdit already forgot them -- //undo 10 doesn't allow WorldEdit to recover more of your previous brush actions. The solution here is to increase history-size or whatever the equivalent property is on your platform.
If you find that this is not the case, please send a video that reproduces the issue, as the given instructions are not clear enough.
Edit: for reference I am using 7.2.0-SNAPSHOT+4918-b4d2db3. Not sure what version you're on, since you just said "latest" which can mean at least two things.
I'm using world edit 1.15.2(Latest), if my history size is 15, and I do say 20 brush actions as you said, if I was to go //undo 25, basically any number higher than my actions, it will say "nothing left to undo" and worldedit forgets the 20 actions u did as well, without undoing them. Yes increasing the history-size fixed the solution for me, because now I can undo // a larger number, but the problem I was having in the beginning was not with //undo for a number smaller than my edits, it was for if I did //undo for a number larger than my edits when my history size was smaller, so I dont think its a bug either, I just think you need a larger history size, otherwise doing anything higher than 15 for //undo caused my worldedit to not undo anything, but keep giving the same message of "nothing left to undo."
world edit 1.15.2(Latest)
still isn't a version number. 1.15.2 is a minecraft version, not a worldedit version. I think octy already demonstrated that this works fine currently.
