WorldEdit

WorldEdit

42M Downloads

Fabric tools perform left click action on right click

zml2008 opened this issue ยท 1 comments

commented

Versions
7.2.0-SNAPSHOT
On MC 1.16.1 in a dev environment

Describe the bug
When right clicking with the farward, both left click and right click actions are performed.

To Reproduce

  1. Bind the farwand tool to an item (in my case, a netherite sword), with cuboid selection mode active
  2. Left click to select one point
  3. Right click and see both points be set to one position (first left, then right).

Expected behavior
Left click would set point one, and right click would only set point two.

Screenshots
n/a

Additional context
Stacktrace from setting a breakpoint on DistanceWand#actSecondary, when right clicking:

actSecondary:49, DistanceWand (com.sk89q.worldedit.command.tool)
handlePlayerInput:377, PlatformManager (com.sk89q.worldedit.extension.platform)
invoke:-1, GeneratedMethodAccessor2 (jdk.internal.reflect)
invoke:43, DelegatingMethodAccessorImpl (jdk.internal.reflect)
invoke:564, Method (java.lang.reflect)
dispatch:58, MethodEventHandler (com.sk89q.worldedit.util.eventbus)
handleEvent:73, EventHandler (com.sk89q.worldedit.util.eventbus)
dispatch:193, EventBus (com.sk89q.worldedit.util.eventbus)
post:181, EventBus (com.sk89q.worldedit.util.eventbus)
handleArmSwing:596, WorldEdit (com.sk89q.worldedit)
onLeftClickAir:246, FabricWorldEdit (com.sk89q.worldedit.fabric)
handler$zcg000$onSwing:47, ServerPlayerEntity (net.minecraft.server.network)
swingHand:1286, ServerPlayerEntity (net.minecraft.server.network)
onHandSwing:1059, ServerPlayNetworkHandler (net.minecraft.server.network)
apply:28, HandSwingC2SPacket (net.minecraft.network.packet.c2s.play)
apply:13, HandSwingC2SPacket (net.minecraft.network.packet.c2s.play)
method_11072:20, NetworkThreadUtils (net.minecraft.network)
run:-1, 480467619 (net.minecraft.network.NetworkThreadUtils$$Lambda$5194)
run:17, ServerTask (net.minecraft.server)
executeTask:136, ThreadExecutor (net.minecraft.util.thread)
executeTask:22, ReentrantThreadExecutor (net.minecraft.util.thread)
executeTask:756, MinecraftServer (net.minecraft.server)
executeTask:1722, MinecraftServer (net.minecraft.server)
runTask:109, ThreadExecutor (net.minecraft.util.thread)
method_20415:736, MinecraftServer (net.minecraft.server)
runTask:730, MinecraftServer (net.minecraft.server)
runTasks:97, ThreadExecutor (net.minecraft.util.thread)
method_16208:715, MinecraftServer (net.minecraft.server)
runServer:670, MinecraftServer (net.minecraft.server)
method_29739:226, MinecraftServer (net.minecraft.server)
run:-1, 100639713 (net.minecraft.server.MinecraftServer$$Lambda$4574)
run:832, Thread (java.lang)
commented

Fixed by f4c4406, forgot to mention in commit.