WorldEdit

WorldEdit

42M Downloads

/tool tree command producing trees with inadequate amount of log blocks

yngmnyaustin opened this issue ยท 4 comments

commented

WorldEdit Version

7.3.0

Platform Version

Forge 1.20.4-49.0.34

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

When using the /tool tree [type] command to generate trees (i.e. [type] = spruce, bigtree, etc.) the resulting trees generated by the command contain an inadequate amount of log blocks, causing leaf blocks to decay unless additional log blocks are manually placed.

Expected Behavior

When using the /tool tree [type] command, the generated tree should contain a number of log blocks, evenly spaced within the leaf blocks, in order to prevent automatic decay of the generated leaf blocks.

Reproduction Steps

  1. Bound the /tool tree [type] command to an eligible item (i.e. Stick)
  2. Choose a block to generate the tree on (i.e. Grass)
  3. Right click to generate tree. The generated tree will not contain enough log blocks to prevent leaf decay.

Anything Else?

No response

commented

Ah, I see. I thought this was a bug as I've been able to use the command to generate trees that didn't decay in previous versions. Perhaps the generation code has changed in a new update? Good to know though.

commented

We don't control what gets generated here, we just tell the game to generate a tree of the given type at the given location. Minecraft does sometimes generate trees with decaying leaves.

I'm not sure this is something we can really do anything about, because it's the game doing this generation, not us. If we were to modify these trees, then people would complain that we don't generate trees correctly because they differ from natural generation

commented

This issue has been automatically marked as stale because it has not been fully confirmed. It will be closed if no further activity occurs. Thank you for your contributions.

commented

image
2024-07-20_11 33 35
I look at these and can identify spots where it's 100% supposed to be logs (green lines in the first one are my addition), in the second image it even has zero trunk. This happens with tool set to tree largeoak and it also happens with //feature fancy_oak.

If I set up a bunch of trees with shafts of cobblestone above them (known way to force large oaks in survival) and just start autoclicking bonemeal onto them, this happens zero percent of the time, leading me to believe it's not the intended vanilla experience. One of those is even the size of the trunkless image from earlier, but has the trunk this time.

Looking around I spotted this explanation of large/big/fancy oak generation which claims the following:

leafDistanceLimit: The distance from a log that leaves can generate, set to 4 for sapling growth, though appears to be set to 5 for natural growth for some reason

I could see this being the root of the problem I'm seeing -- if the worldgen tree feature generator still works like this, then worldedit calling it is just happening to give me branches with lengths short enough where their leaves block spheres overlap where the trunk goes. But I don't know where to look to see if that's how tree generation still works beyond the fact that I can't see it happening in several dozen bonemealed examples.

Everything tested in fabric.