WORLDEDIT-2221 - Reported by rtcabooservb

Few things I found interesting about butcher.

#1. Even if a default radius is set in the config, it will still butcher all mobs in the whole world, no matter what rank.
#2. Butcher config section is the only section that has extra spacing? http://pastebin.com/KPCbTuMK
#3. No way to force a maximum butcher radius?

Comment by rtcabooservb

Great job with the fix! I'll get right on it to verify it works as intended now. However, is it possible to add permissions for every worldedit butcher feature so I don't have users running around with /butcher -a?

Comment by rtcabooservb

I typed /butcher and it killed 1500 mobs. It still didn't limit the radius to 25. I want to force it to a radius of 25, so they can't butcher all the mobs in the world. I would also like to disable certain features like -a, -g, -n, -f, and -l so they can't use it.

Comment by wizjany

Each flag has a permissions that you can assign.

Comment by rtcabooservb

Do you have a list of permissions for butcher? Since the wiki is outdated. Also, it does not force a limit of 25. Is there a bypass permission?

Comment by wizjany

        flags.or(KillFlags.FRIENDLY      , args.hasFlag('f'));
        flags.or(KillFlags.PETS          , args.hasFlag('p'), "worldedit.butcher.pets");
        flags.or(KillFlags.NPCS          , args.hasFlag('n'), "worldedit.butcher.npcs");
        flags.or(KillFlags.GOLEMS        , args.hasFlag('g'), "worldedit.butcher.golems");
        flags.or(KillFlags.ANIMALS       , args.hasFlag('a'), "worldedit.butcher.animals");
        flags.or(KillFlags.WITH_LIGHTNING, args.hasFlag('l'), "worldedit.butcher.lightning");

Radius should be fixed, also added a max radius option
You probably need to regen your config (or copy the appropriate settings into the right place)

Comment by rtcabooservb

Just tried it again on an alternate account that is not an admin or OP, but has the permission worldedit.butcher. It killed 3,000 mobs. So I assume it still does not work. Using jenkins build #1298. If you were in the #sk89q IIRC channel, it would be much faster to report if it works or not.

In the config:
butcher:
default: 25
maximum: 25

Comment by rtcabooservb

To elaborate, I just typed /butcher, not /butcher 25. I want to force /butcher to a radius of 25 so users can't butcher the whole world.

Comment by wizjany

Those config settings don't look right. Make sure you completely delete the config file or correctly insert the lines into the limits section.

Comment by rtcabooservb

I took the config settings straight from the source of the commit.
https://github.com/sk89q/worldedit/blob/56d534bf0dce89d0ad692b954249a7dfdacc9d5d/src/main/resources/config.yml

As I can see, you moved it in the config section. I will move it to the limits: section and try again.