Block limits should apply to //copy
LadyCailinBot opened this issue ยท 3 comments
WORLDEDIT-3232 - Reported by Zane.Woodard
I had to write a plugin that wrapped the command to achieve this functionality in WorldEdit 5.x. Unfortunately, it broke for WorldEdit 6.x, and I'm looking to patch it but thought I'd try getting an official patch for this.
Basically, either //copy should get its own limit in the config, or it should be restricted to the same max block change limits as every other command. Currently, no limits apply to copy. This makes it a very unsafe command to give to regular players, as it can be easily abused to lag out the server or cause excessive memory usage.
If the entire clipboard system had to be rewritten to make it obey limits, I would understand why //copy had no limits. However, it's a simple patch to add a size check to the region at the top of the copy function, so I don't think this is too much to ask for.
Comment by sk89q
The ongoing plan is to make //copy occur over several ticks, though this has not yet been done.
Comment by Zane.Woodard
Even if it does occur over several ticks, shouldn't it be constrained by some limit (either a new one in the config, or an existing one)? Even if it doesn't cause any issues while copying, the fact that it would allow players to get WorldEdit to store near-arbitrary amounts of the map in their clipboard could allow players to use up all available memory.