WTHIT Forge Edition

WTHIT Forge Edition

3M Downloads

Mob hearts use player heart texture instead

Cloud7050 opened this issue ยท 3 comments

commented

Describe the bug
Mob hearts in the tooltip use the player heart texture instead of the mob heart texture. But it correctly uses the mob heart outline texture. This is a bug also present from HWYLA, but I guess that's not getting fixed there.

To Reproduce
Use a resource pack where the mob hearts + outline look different from player hearts + outline.
Start the game and ensure mod config displays animals.
Spawn an animal like a pig and look at it.

Expected behavior
Mod tooltip should use mob heart texture + mob outline texture, instead of player heart texture + mob outline texture

Setup

  • Minecraft: 1.16.5
  • Fabric Loader: fabric-loader-0.11.1-1.16.5
  • Fabric API: fabric-api-0.34.0+1.16
commented

Yeah, it'll use the player outline. Mob hearts only make sense for rideable mobs since vanilla use it only for that

commented

Is mob heart the pink one or the saddle one? If it's the latter then I'm not sure it'd make sense on hostile mob...
I'll probably make the outline use player's one

commented

Screenshot 2021-05-13 002552

I have marked some boxes in the image above. For players, the mod uses green + blue. For mobs, it uses orange + blue. In vanilla, this works fine because the green and orange ones are the same texture. But for custom resource packs that change the hearts such that player and mob hearts have different outlines, orange + blue no longer works because they don't match, so you end up with a wrong-looking outline for mobs.

Your mentioned green + blue for both players & mobs would make sense if you find the "saddle" mob hearts to be odd. That would be an appreciated fix.