Crash in Plugin Settings Screen
MorningSage opened this issue ยท 2 comments
Describe the issue
Game crash when opening the plugin settings screen with Botany Pots and Waila Harvestability.
Log
https://gist.github.com/MorningSage/953a96c72879637e8a286d71bf94308c
To Reproduce
- Load up an instance of the game with the following mods/versions:
- Minecraft 1.16.5
- Forge 36.2.2
- WTHIT 2.10.5
- Botany Pots 7.0.17
- Bookshelf 10.2.15 (Dependency of Botany Pots)
- Waila Harvestability 1.1.15
- Navigate to WTHIT settings by using the keybind (Default NumPad0)
- Click on the "Plugin Settings" button
Expected behavior
Expected behavior is for WTHIT to list the available plugins for further selection by the user for customization. Instead, the game crashes with java.lang.IllegalArgumentException: Comparison method violates its general contract! as noted in the above log.
Additional context
Including either mod by themselves does not appear to crash the game. However, when used in conjunction, the game consistently crashes.
Presumably, this is because in this line, the value of -1 is returned when o1.getNamespace() == WailaConstants.WAILA but doesn't account for the situation where o1.getNamespace() == o2.getNamespace() == WailaConstants.WAILA where returning 0 would be appropriate?
I don't know what I'm talking about and why it would crash when only those two are present, I have no clue. So take that with a grain of salt, lol.