Wynntils

Wynntils

611k Downloads

Test Result of Item Tier / Scroll Letters

Kepler-17c opened this issue ยท 9 comments

commented

Success:

  • scrolls have the town letter
  • powders have their tier

Fail:

  • Town pairs like Nesaak and Nemract get same letter
  • boat passes don't have letters
  • broken keys where the Forgery note is missing don't have letters
  • old dungeon keys don't have letters
  • emerald pouches don't have their tier
commented

Seems like the rendering is done based on the first letter of the item, which shouldn't be the case, and if it is, consider adding checks;

image

Rendering on Auction Page is wrong.

image

And the inner view further confirms my suspicion the rendering is done based on the first character of the item

commented

Town pairs like Nesaak and Nemract get same letter

this is the same behavior as legacy - i'm not sure how we could convey these differences easily

boat passes don't have letters

not implemented yet

old dungeon keys don't have letters

is this really a valuable functionality?

emerald pouches don't have their tier

not implemented

commented

I fear that might be too bulky ๐Ÿค”
How about first 2?

commented

Well first 2 would not solve the problem in the first place - NEmract and NEsaak

commented

Ah, true :/

commented

this is the same behavior as legacy - i'm not sure how we could convey these differences easily

Probably needs specific exceptions - could use syllables (e.g. NA = Nesaak / NR = Nemract / RN = Ragni / RL = Relos / CK = Corkus / CF = Cinfras / ...)

is this really a valuable functionality?

Not really, but it would be cool to have them treated the same way as modern keys.

not implemented

I guessed so, but wanted to point it out anyway, so there's a note for planning and future updates.

commented

Town pairs like Nesaak and Nemract get same letter
this is the same behavior as legacy - i'm not sure how we could convey these differences easily

Since this bit is being rewritten anyway, the town names could get a 2 or 3 letter abbreviation
I felt like the 2 letters were really useful for the dungeon keys, and this could probably benefit the same way

oh kepler was already typing

commented

The syllable thing doesn't allow things like using the first two words (e.g. Lost Sactuary -> LS), so it probably needs a hard-coded map of town name to abbreviation (should be fine though, as they barely change)

commented

Is hard-coded necessary? I feel like the first three letters of each town name works quite well for nearly every town off the top of my head

RAGni
DETlas
CINfras
AHMsord
LUTho
ALMuj
SELchar
OLUx
GELibord

The only two I didn't really like were CORkus and TROms, but honestly even they are okay