Find a better solution for expressing ambiguity in ActivityType
magicus opened this issue ยท 2 comments
This is since ContentType.from(type)
will not work for type == "Discovery".
I think we need a better way to handle "ambiguous" types like "Quest" (can be Mini-Quest, Storyline Quest or normal Quest) and "Discovery" (can be Secret, World or Territorial Discovery). Need to think a bit about that.
@magicus this is fixed? Or do you want this to stay until the hacky fix is in? What is even hacky about it?
I hard-coded a return of "Territorial Discovery", even if it is a World Discovery (or the other way round). Which means it will display the wrong header in the overlay.
I think we need a way to handle the ambiguous activity types, like "storyline quest" and "quest" which is on the same filter page, and "storyline quest", "quest" and "mini-quest" which all show up as just "Quest" on the scoreboard tracker. (And similar for discoveries.) Possibly the solution is to lookup the name of the activity of the tracker to get the correct type.
I think we can keep the bug to solve this properly, but there is no NPE. I'll update the title.