Wynntils

Wynntils

Mods
611k Downloads

Breaks main menu with the continue button mod

MenacingPerson opened this issue ยท 3 comments

commented

https://modrinth.com/mod/continue

How it looks:

image

After pressing options button and esc (fixed, looks normal):

image

According to that mod's author:

image

The wynntils button looks like it merged with the multiplayer button.

commented

We're doing this:

        WynncraftButton wynncraftButton = new WynncraftButton(
                titleScreen, wynncraftServer, titleScreen.width / 2 + 104, titleScreen.height / 4 + 48 + 24);
        titleScreen.addRenderableWidget(wynncraftButton);

Continue does this:

        continueButtonBuilder.dimensions(this.width / 2 - 100, y, 98, 20);
        continueButtonWidget = continueButtonBuilder.build();
        Screens.getButtons(this).add(continueButtonWidget);

where Screens is the Fabric API: net.fabricmc.fabric.api.client.screen.v1.Screens.

It is not immediately clear why this is causing a conflict.

commented

It's not so much a Wynntils issue as a problem with the interaction between Wynntils and Continue. After all, Continue claims "Compatible with Mod Menu and most mods that modify the main menu". ;-)

We'll need to figure out what assumptions Continue make about the buttons that we break.

commented

I could confirm this with just Wynntils, FAPI, Continue Button, and LazyDFU on 1.19.4, everything freshly downloaded so latest.

image