ChatManager wrong chat type
kristofbolyai opened this issue · 12 comments
@magicus
[21:45:06] [Render thread/INFO] (Minecraft) [CHAT] BACKGROUND-PARTY: §r§8[§r§7VIP+§r§8] §r§7FancyFedora§r§8 has just logged in!
This breaks InfoMessageFilterFeature as expected.
Shift clicking soul points, assigned different types, not sure if that is what you want.
What is the distinction between the messagetypes normal and system? As I expected bomb bells to be classified as system, but they're not.
@HighCrit THe difference is if Wynncraft tags the chat packet as CHAT or SYSTEM. I don't know the reason for their choice, or if it has any practical difference. (They look the same to the user.) I assume this is a vanilla distinction that does not really apply to Wynncraft. But the difference is yet another clue for us to correctly differentiate between certain types of messages.
@kristofbolyai With different types, you mean SYSTEM/NORMAL? As I said to HighCrit above, that is basically just reporting what Wynncraft choose.
@kristofbolyai With different types, you mean SYSTEM/NORMAL? As I said to HighCrit above, that is basically just reporting what Wynncraft choose.
Yeah, it is fine them, except the issue description.
@HighCrit THe difference is if Wynncraft tags the chat packet as
CHATorSYSTEM. I don't know the reason for their choice, or if it has any practical difference. (They look the same to the user.) I assume this is a vanilla distinction that does not really apply to Wynncraft. But the difference is yet another clue for us to correctly differentiate between certain types of messages.
Late, but vanilla client allosw user to filter SYSTEM or something.
This also should be fixed by #296, so closing until if it reappears.
What do you mean? The general advertising done by Wynncraft is not filtered. This is due to two reasons:
- It's a lot of different messages, and hence a lot of additional filters, and
- I felt it was not really fair -- Wynncraft need their chance to do some advertising. (I might reconsider this point if the user has a paid rank, then they have contributed and know about the situation.)