Wynntils

Wynntils

611k Downloads

Hero's range visualizer

ariszz opened this issue · 5 comments

commented

The Hero's major ID range visualizer wasn't working for me in beta.102, so I switched back to beta.50, which resolved the issue. Found out that it stops working in beta.79 and so on.

Fabric: 0.15.3
Artemis: v0.0.4-beta.102

commented

beta.79 includes a single PR, #2271. Are you saying the visualizer worked up until 78, but stopped working in 79?

There is nothing obvious in #2271 that would break the hero's range visualizer, but perhaps gear identification was affected by the changes in it.

commented

A few patches earlier we did change the feature to use the major id names, not the wynn internal names. I've checked it and nothing looks visually wrong, and Guardian also works. So I am not sure what happened..

commented

It probably is. I'll fix it up later.

commented

Hero's major ID is "Saviour’s Sacrifice", but in the code, it is "Saviour's Sacrifice" with an apostrophe instead of a right single quotation mark. Could this be the issue?
image

commented

Fixed in #2301