ContainerSetContentEvent.Pre event is not fired if inventory is full, causing jump buttons in bank to stop working

Question

ContainerSetContentEvent.Pre event is not fired if inventory is full, causing jump buttons in bank to stop working

Twisted-Code opened this issue 3 months ago · 29 comments

Twisted-Code commented 3 months ago

At some point within the past 24 hours, I think probably more like past 12 hours, the page jump buttons the mod adds on the left side of the personal/account bank GUI (which I presume is actually just a reskinned ender chest and you figure out whether to show the buttons based on context, right?) have ceased working. I click them and they make the click sound but do nothing. I cannot think of anything I did, any changeset within my control, that's likely to have caused this.
What do they depend on in order to work?

Twisted-Code commented 3 months ago

🤔

Twisted-Code · Answer 1 · 2024-08-26T02:47:03.000Z

And just as mysteriously the feature started working again... I'm going to leave this open in case it recurs or you can provide insight into what I may be doing to trigger it, but for now I'm kind of scratching my head and just happy it's working again.

Twisted-Code · Answer 2 · 2024-08-26T01:11:50.000Z

I am suspicious of this download link. First of all, it's not working even after I disabled my various privacy extensions. Second of all, it would really help if you could elaborate on what it's supposed to do.

kristofbolyai · Answer 3 · 2024-08-26T03:46:11.000Z

I've deleted the malicious user's links and reported them to Github.

Twisted-Code · Answer 4 · 2024-08-29T19:55:40.000Z

Apparently @github-staff didn't like my sarcastic remark about the loophole in their moderation policies. (I also quoted the malicious user, but I don't think it was that since I redacted the link from the quote)
Thank you for addressing the malicious comments, Kristof.
Back on topic, any idea what might've been causing my issue, so I can avoid triggering it again? The only thing I've discovered since is that it can also happen when my inventory is full, but I don't think my inventory was full in all cases where I had this issue.

magicus · Answer 5 · 2024-08-29T21:13:36.000Z

That is really absurd. I saw your comment; there was nothing in it to warrant a removal. I fully agree with you about the loophole. Pointing that out should hardly be a cause for removal of a comment.

As for the actual issue; I have no idea what can go wrong. I suspect more data on when this happens and under what conditions would be helpful. If you know how to access the Minecraft log, you can also have a look at if if anything shows up when you click the buttons without effect, or if something sus showed up prior to the buttons stopped working.

Twisted-Code · Answer 6 · 2024-08-30T13:49:58.000Z

Re: comment deletion: tbh, I might ask github support about it later (smells like an automation bug), but it's not a priority.

Re: actual issue: I do agree that data would be helpful, maybe to point us in the right direction. Unfortunately I cannot remember exactly which Minecraft log I should be looking at, but I'll see if I can figure it out based on the date/time I posted this.

kristofbolyai · Answer 7 · 2024-08-31T07:54:40.000Z

Those logs have nothing really that should warrant this issue, in fact it's likely caused by items and item sets not being updated to the latest game data, which is partially fixed now. Can you reproduce this log with Wynntils 2.1.0?

Twisted-Code · Answer 8 · 2024-08-31T02:54:46.000Z

Okay I don't know about last time, but just now I had the issue crop up the almost the exact instant that this warning appeared in my log:

[22:35:49] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:35:49] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:35:49] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:35:49] [Render thread/WARN]: Tier for Snow Helmet is reported as null
[22:35:49] [Render thread/WARN]: Error:Relic Leggings claims to have identification StatType[key=DEFENCE_ELEMENTAL, displayName=Elemental Defence, apiName=elementalDefence, internalRollName=ELEMENTALDEFENSE, unit=PERCENT]
[22:35:49] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:35:49] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:35:49] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:35:49] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:35:49] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:35:49] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:35:49] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:35:49] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:35:54] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:35:54] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:35:54] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:35:54] [Render thread/WARN]: Tier for Snow Helmet is reported as null
[22:35:54] [Render thread/WARN]: Error:Relic Leggings claims to have identification StatType[key=DEFENCE_ELEMENTAL, displayName=Elemental Defence, apiName=elementalDefence, internalRollName=ELEMENTALDEFENSE, unit=PERCENT]
[22:35:54] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:35:54] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:35:54] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:35:54] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:35:54] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:35:54] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:35:54] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:35:54] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:36:00] [Render thread/WARN]: Ignoring player info update for unknown player d730e3f1-4ec9-2007-9298-8ebb73af6055 ([UPDATE_DISPLAY_NAME])
[22:36:01] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:36:01] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:36:01] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:36:01] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:36:02] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:36:02] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:36:02] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:36:02] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:36:05] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:36:05] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:36:05] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:36:05] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:36:05] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:36:05] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:36:05] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:36:05] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:36:06] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:36:06] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:36:06] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:36:06] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:36:18] [ForkJoinPool.commonPool-worker-8/ERROR]: Athena user lookup has repeating failures for user SparkTC. Disabling future lookups for the user, until a reset.
[22:36:18] [Render thread/WARN]: Ignoring player info update for unknown player d730e3f1-4ec9-2007-9298-8ebb73af6055 ([UPDATE_DISPLAY_NAME])
[22:36:25] [ForkJoinPool.commonPool-worker-1/WARN]: Failure in net manager [handleJsonObject], processing API:API_ATHENA_USER_INFO: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 2 column 2 path $
[22:36:25] [ForkJoinPool.commonPool-worker-1/ERROR]: Athena user lookup has repeating failures for user RomaSol. Disabling future lookups for the user, until a reset.
[22:36:39] [Render thread/INFO]: [CHAT] &4You have &c&l2 unused Skill Points&4 and &b&l1 unused Ability Point! &4Right-Click while holding your compass to use them
[22:36:39] [Render thread/INFO]: Message Queued: TextRenderTask[text=StyledText{'Â§4You have Â§l2Â§rÂ§4 unused skill points'}, setting=TextRenderSetting[maxWidth=0.0, customColor=#ffffffff, horizontalAlignment=LEFT, verticalAlignment=TOP, shadow=NORMAL]]
[22:36:39] [Render thread/INFO]: Message Queued: TextRenderTask[text=StyledText{'Â§3You have Â§l1Â§rÂ§3 unused ability points'}, setting=TextRenderSetting[maxWidth=0.0, customColor=#ffffffff, horizontalAlignment=LEFT, verticalAlignment=TOP, shadow=NORMAL]]
[22:36:43] [ForkJoinPool.commonPool-worker-8/ERROR]: Athena user lookup has repeating failures for user HIHI0406TW. Disabling future lookups for the user, until a reset.
[22:36:45] [Render thread/WARN]: Ignoring player info update for unknown player d730e3f1-4ec9-2007-9298-8ebb73af6055 ([UPDATE_DISPLAY_NAME])
[22:37:06] [ForkJoinPool.commonPool-worker-8/ERROR]: Athena user lookup has repeating failures for user Zophiya. Disabling future lookups for the user, until a reset.
[22:37:25] [Render thread/INFO]: [CHAT] &7î�–î�‚î�¤î�£&r &8î€�â�¤î�°&fî�±î�¡&8î€�&fî€’î� &8î€�&fî€’î�¥&8î€Ž&fî€’â�¤â�¤î€®&8î€�&fî€’î�€&8î€�&fî€’î�•&8î€�&fî€’î�Ž&8î€‘â�¤&r &#54fcfcffî�½ â�¤&rî€›î€“â�¤â�¤&#a344aaff&oBalls of Fury&r&#a344aaff: &fi wanna check hq tho
[22:37:25] [Render thread/INFO]: [System] [CHAT] î�–î�‚î�¤î�£ î€�â�¤î�°î�±î�¡î€�î€’î� î€�î€’î�¥î€Žî€’â�¤â�¤î€®î€�î€’î�€î€�î€’î�•î€�î€’î�Žî€‘â�¤ î�½ â�¤î€›î€“â�¤â�¤Balls of Fury: i wanna check hq tho
[22:37:25] [Render thread/INFO]: [System] [CHAT] î�–î�‚î�¤î�£ î€�â�¤î�°î�±î�¡î€�î€’î� î€�î€’î�¥î€Žî€’â�¤â�¤î€®î€�î€’î�€î€�î€’î�•î€�î€’î�Žî€‘â�¤ î�½ â�¤î€›î€“â�¤â�¤Balls of Fury: i wanna check hq tho
[22:37:30] [Render thread/WARN]: Ignoring player info update for unknown player d730e3f1-4ec9-2007-9298-8ebb73af6055 ([UPDATE_DISPLAY_NAME])
[22:37:38] [Render thread/INFO]: [CHAT] &4You have &c&l2 unused Skill Points&4 and &b&l1 unused Ability Point! &4Right-Click while holding your compass to use them
[22:37:38] [Render thread/INFO]: Message Queued: TextRenderTask[text=StyledText{'Â§4You have Â§l2Â§rÂ§4 unused skill points'}, setting=TextRenderSetting[maxWidth=0.0, customColor=#ffffffff, horizontalAlignment=LEFT, verticalAlignment=TOP, shadow=NORMAL]]
[22:37:38] [Render thread/INFO]: Message Queued: TextRenderTask[text=StyledText{'Â§3You have Â§l1Â§rÂ§3 unused ability points'}, setting=TextRenderSetting[maxWidth=0.0, customColor=#ffffffff, horizontalAlignment=LEFT, verticalAlignment=TOP, shadow=NORMAL]]
[22:38:00] [Render thread/INFO]: [CHAT] &#00bdbfffó�¿¼î€�ó�¿¿î€‚ó�¿¾ The Canine Ambush World Event starts in 
ó�¿¼î€�ó�€† 2m! &7(143 blocks away) &d&nClick to track
[22:38:00] [Render thread/INFO]: [System] [CHAT] ó�¿¼î€�ó�¿¿î€‚ó�¿¾ The Canine Ambush World Event starts in \nó�¿¼î€�ó�€† 2m! (143 blocks away) Click to track
[22:38:00] [Render thread/INFO]: [System] [CHAT] ó�¿¼î€�ó�¿¿î€‚ó�¿¾ The Canine Ambush World Event starts in \nó�¿¼î€�ó�€† 2m! (143 blocks away) Click to track
[22:38:15] [Render thread/WARN]: Ignoring player info update for unknown player d730e3f1-4ec9-2007-9298-8ebb73af6055 ([UPDATE_DISPLAY_NAME])
[22:38:37] [Render thread/INFO]: [CHAT] &4You have &c&l2 unused Skill Points&4 and &b&l1 unused Ability Point! &4Right-Click while holding your compass to use them
[22:38:37] [Render thread/INFO]: Message Queued: TextRenderTask[text=StyledText{'Â§4You have Â§l2Â§rÂ§4 unused skill points'}, setting=TextRenderSetting[maxWidth=0.0, customColor=#ffffffff, horizontalAlignment=LEFT, verticalAlignment=TOP, shadow=NORMAL]]
[22:38:37] [Render thread/INFO]: Message Queued: TextRenderTask[text=StyledText{'Â§3You have Â§l1Â§rÂ§3 unused ability points'}, setting=TextRenderSetting[maxWidth=0.0, customColor=#ffffffff, horizontalAlignment=LEFT, verticalAlignment=TOP, shadow=NORMAL]]
[22:38:51] [Render thread/INFO]: Loaded 829 advancements
[22:38:51] [Render thread/INFO]: Loaded 1642 advancements
[22:38:54] [ForkJoinPool.commonPool-worker-8/ERROR]: Athena user lookup has repeating failures for user santorini. Disabling future lookups for the user, until a reset.
[22:38:58] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:38:58] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:38:58] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:38:58] [Render thread/WARN]: Tier for Snow Helmet is reported as null
[22:38:58] [Render thread/WARN]: Error:Relic Leggings claims to have identification StatType[key=DEFENCE_ELEMENTAL, displayName=Elemental Defence, apiName=elementalDefence, internalRollName=ELEMENTALDEFENSE, unit=PERCENT]
[22:38:58] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:38:58] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:38:58] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:38:58] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:38:58] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:38:58] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:38:58] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:38:58] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:39:00] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:00] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:00] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:00] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:00] [Render thread/WARN]: Ignoring player info update for unknown player d730e3f1-4ec9-2007-9298-8ebb73af6055 ([UPDATE_DISPLAY_NAME])
[22:39:02] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:02] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:02] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:02] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:03] [Render thread/WARN]: Ignoring player info update for unknown player d730e3f1-4ec9-2007-9298-8ebb73af6055 ([UPDATE_DISPLAY_NAME])
[22:39:04] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:04] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:04] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:04] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:39:06] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:06] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:06] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:06] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:39:07] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:07] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:07] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:07] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:39:08] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:08] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:08] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:08] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:09] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:09] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:09] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:09] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:14] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Helmet has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:14] [Render thread/WARN]: Tier for Snow Helmet is reported as null
[22:39:14] [Render thread/WARN]: Error:Relic Leggings claims to have identification StatType[key=DEFENCE_ELEMENTAL, displayName=Elemental Defence, apiName=elementalDefence, internalRollName=ELEMENTALDEFENSE, unit=PERCENT]
[22:39:14] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:14] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:14] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:14] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:14] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:14] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:39:14] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:14] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:14] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:39:17] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:17] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:17] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:17] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:19] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:19] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:19] [Render thread/WARN]: Item Snow Tunic has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:19] [Render thread/WARN]: Tier for Snow Tunic is reported as null
[22:39:20] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:20] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:20] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:20] [Render thread/WARN]: Tier for Snow Boots is reported as null
[22:39:21] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{ }[style={color=dark_purple,!italic}]
[22:39:21] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7[0/2] Powder Slots}[style={color=dark_purple,!italic}]
[22:39:21] [Render thread/WARN]: Item Snow Boots has unknown set bonus stat line: literal{Â§7}[style={color=dark_purple,!italic}, siblings=[literal{Set Item}[style={color=#55FF55}]]]
[22:39:21] [Render thread/WARN]: Tier for Snow Boots is reported as null

I then noticed that it was jumping to the page right before the page on which some Snow Boots, and I also had them in my inventory. For some reason, if I put both items into my storage, it is (at least based on testing so far) able to jump without issues.

My current hypothesis: it's getting the different instances of this item mixed up. Why does this error cause it to not change pages though? Is the error perhaps getting thrown before the page is actually turned, and then caught by an error handler several scopes higher on the stack[*]?

[*]Approximate anthropomorphism of that error handler's inner logic: "What an inventory? I just stop render errors from crashing the program. What's Minecraft? Hey log4j, can you save this nonsense for me? Maybe someone else will know what I should be doing"

Twisted-Code · Answer 9 · 2024-08-31T23:26:33.000Z

I update the mod this morning, and according to the version command I'm now running 2.1.1. I'll let you know if it happens again.

magicus · Answer 10 · 2024-09-01T08:34:36.000Z

Those logs have nothing really that should warrant this issue, in fact it's likely caused by items and item sets not being updated to the latest game data, which is partially fixed now.

Perhaps, but they did give a clue that the new items might have been involved.

ShadowCat117 · Answer 11 · 2024-09-01T10:27:07.000Z

The feature doesn't log anything at the moment, so I'm not sure how useful logs would be anyway. I could make it log things like Trying to jump to page 5 or Arrived at page 5 to see if that could help diagnose the issue

Twisted-Code · Answer 12 · 2024-09-01T18:14:14.000Z

If you can figure it out from this log, from 2.1.1, great; otherwise, I think adding some debug lines would probably be for the best. All I'm doing at this point is:

launch the game
log in
open my bank, and click one of the jump buttons
Issue occurs. Got stuck on page 9 when trying to jump to 10.
latest.log
FWIW, last night I also got stuck on page <i don't remember what number> trying to jump to 11. I don't think it's anything with a specific page number. My guess remains that there is something with the state of the bank pages causing the issue, such as which items or how many items.
I don't think it will happen on a clean slate (and can't easily empty my bank anyway) but if I did and could, that would be my next step on my end.

Twisted-Code · Answer 13 · 2024-09-01T18:22:59.000Z

This issue did not recur when I restarted the game again, or at least not after making some space in my main inventory. Interesting that when it did occur, it stopped on page 9, one page short of the intended page. Then it started happening again when I filled my inventory back up.
I'm not yet sure if it can occur without my main inventory being full, at least on this mod version.

Twisted-Code · Answer 14 · 2024-09-01T18:35:52.000Z

Even after rearranging my bank (in particular, adding some ingredients to page 10 and moving the snow armor I mentioned earlier to page 9), it continues to get stuck on page 10... if my main inventory is full.
Are you having issues with double digits somehow?

ShadowCat117 · Answer 15 · 2024-09-01T18:45:37.000Z

Can you confirm a few things for me.

What type of container is this, account bank, misc bucket etc.
What page are you starting at.
What page are you trying to jump to.
What pages do you have unlocked.
Have you visited your last page?

Twisted-Code · Answer 16 · 2024-09-01T20:30:26.000Z

type of container: account bank
Starting page: first page but I think I've tried other pages
Target page: 10. I think I also tried 11 at one point
Highest page unlocked: up to 11
Last page visited: no, and IIRC the problem temporarily goes away if I visit it (but only until closing and reopening the storage)

I'm curious what the relevance of that last question is, is there some sort of caching/indexing behavior that might be involved here? I thought the fact it temporarily fixes the issue was curious but forgot to mention it, thank you for asking!

ShadowCat117 · Answer 17 · 2024-09-01T20:41:29.000Z

The way it works, is that it tries to jump to the closest available page that the vanilla quick jumps can. Account bank can jump directly to 11 so it will try and do that.

However, if you do not have that page unlocked then you can't use that quick jump so the mod needs to know what your last page is, so if you want to jump to page 10, but you don't have page 11 unlocked then it knows to not try and jump there and it will instead try and jump to 9, then click the next page button to reach 10.

By default, the final page is set to the max pages for each bank type, in this case 21, so that every single user does not have to visit their final page before the jumps become available. Once you visit that final page it will update your known final page, however if you've said you have visited it I presume it's not being saved.

Can you check in your .minecraft or whever your installation is for the wynntils/storage/{uuid}.data.json file, where uuid is for the account you're using. And look for model.bank.finalAccountBankPage and tell me what number is there

Twisted-Code · Answer 18 · 2024-09-01T21:07:16.000Z

Okay I figured it was something like that, that's why I was thinking of caching.
Following your instructions, I was momentarily confused as I tried to open the file from a Win + R (Run) Dialog, but it seems it's just not a hyphenated UUID like, for instance, a player.dat filename.
At line 101093 of the JSON:
"model.bank.finalAccountBankPage": 11,
So it's saving, but could it perhaps be having difficulty loading, or maybe some issue unrelated to how it figures out where it can jump? I think it's jumping to 9 and then getting stuck.

Twisted-Code · Answer 19 · 2024-09-01T21:49:21.000Z

Side note, is there somewhere I can send the npc/node location data that's collected in this file so I can shrink it and see if the length is an issue (Without having to make a temp file)? Depending on how picky the parser is it might be choking on the 3 MB file. I know there's no strict limit on the JSON standard but the parser can set an arbitrary limit and could have set it that low for performance for all I know (since I haven't worked with any parser other than Python's JSON lib) 🤷

Twisted-Code · Answer 20 · 2024-09-02T02:30:38.000Z

I've made an observation related to the "full inventory" case of this issue. The following things happen or don't happen when my inventory is full and I click ANY page number (not just 10):

It makes the clicking sound
If the target page is the same as the page title currently displayed (see point 4), do not proceed past this step
it jumps to the nearest "vanilla" jump page
the page title fails to update to the new page, and as noted in step 2, it will not jump back to the page it thinks it's on.

Hypothesis: An exception is being thrown (or it is otherwise being caused to abort the operation) after it changes page with the number key, but before it can now get moved to the adjacent page and update the page title. Since this occurs when the inventory is full, maybe it is unable to pick up the arrow item onto the cursor?

Also since I've only been able to consistently repro the "my inventory is to full" variant of the issue, should I rename this issue and open a new issue if the variant with snow armor resurfaces?

magicus · Answer 21 · 2024-09-02T08:10:34.000Z

You can just turn off crowdsourcing for npc data. We do not handle any crowdsource data at the moment anyway.

ShadowCat117 · Answer 22 · 2024-09-02T13:09:55.000Z

Can confirm, the ContainerSetContentEvent.Pre event is not fired if your inventory is full, causing the issue

Twisted-Code · Answer 23 · 2024-09-02T13:12:53.000Z

Re: crowdsourcing: I don't mind collecting the data (I could potentially use it myself TBH), I was merely wondering if there was somewhere to the send the data already collected or if I should just move it to a separate file to test. Although given ShadowCat's reply about 2 minutes ago, I think it's less likely that the file is contributing to the issue.

magicus · Answer 24 · 2024-09-02T14:28:13.000Z

Nice troubleshooting, @Twisted-Code and @ShadowCat117 btw! This one was not easy.

magicus · Answer 25 · 2024-09-02T14:27:11.000Z

Due to resource constraints, we have unfortunately not been able to write any code for crowdsource data processing in general. :-( From time to time, we do ad-hoc processing, after requesting help in Discord.

Twisted-Code · Answer 26 · 2024-09-14T19:41:29.000Z

I'm having a related issue again, where my inventory is not full but it will not jump to any page ~~to the right of (i.e. index greater than) the one I'm on when I attempt to jump.~~ after page 3.
Although since there appear to be 2 issues I will simply create a new issue and reference it....
here!

Share to