Wynntils

Wynntils

611k Downloads

Chat clickables not always working

kristofbolyai opened this issue ยท 5 comments

commented

There is a case in vanilla where this happens, just want to check this is not the case here. If this happens:

  1. you get a link in chat
  2. you talk to a NPC
  3. after talking, the old "screen" is restored

In this case, the "restore" in 3 does not restore links.

WIth the NPC dialogue overlay, this problem should be avoided.

commented

I saw this behavior myself. It was immediately upon login to a new world/class, when Wynntils dumps a whole lot of messages at once. Then they are sent as a multiline screen, but (apparently) with proper Component contents available.

That means that I either need to make a function to split a massive Component constructor on line breaks (I'm not fond of writing that function!), or I need to find a way to encode Components into strings that does not lose any information (basically, finding a way to store hover and onClick data). This I've actually been thinking about for a while (it was needed for translation as well), and it seems like a more doable way, but it is still quite some effort.

I'll open a separate bug to track my thinking on the issue.

commented

See #292

commented

I'm starting to think this might be TranslationsFeature that is responsible. Are you sure you have it turned off?

commented

Tracking this in #292.